Fix #1645, Add resource ID API functional tests#1716
Merged
astrogeco merged 1 commit intonasa:integration-candidatefrom Aug 9, 2021
nmullane:fix1645-es-resource-id-functional-tests
Merged
Fix #1645, Add resource ID API functional tests#1716astrogeco merged 1 commit intonasa:integration-candidatefrom nmullane:fix1645-es-resource-id-functional-tests
astrogeco merged 1 commit intonasa:integration-candidatefrom
nmullane:fix1645-es-resource-id-functional-tests
Conversation
astrogeco
added
the
CCB:Ready
zanzaben
approved these changes
Aug 9, 2021
skliper
suggested changes
Aug 9, 2021
Contributor
skliper
left a comment
skliper
left a comment
There was a problem hiding this comment.
Also test for range, should be within maximum allowed. Comment comes from a previous similar test, which I think is still valid here.
Contributor
Author
There is an issue for this with an associated branch on my fork that does this, but Gerardo suggested I create a second PR for that once this is merged. |
skliper
approved these changes
Aug 9, 2021
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Aug 9, 2021
2 tasks
astrogeco
added
CCB:Approved
Contributor
|
CCB:2021-08-11 APPROVED
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Testing performed
Steps taken to test the contribution:
Expected behavior changes
A clear and concise description of how this contribution will change behavior and level of impact.
System(s) tested on
Contributor Info - All information REQUIRED for consideration of pull request
Niall Mullane - GSFC 582 Intern