Fix #1690, Tests for time conversion api#1707
Merged
astrogeco merged 1 commit intonasa:integration-candidatefrom Aug 4, 2021
Merged
Fix #1690, Tests for time conversion api#1707astrogeco merged 1 commit intonasa:integration-candidatefrom
astrogeco merged 1 commit intonasa:integration-candidatefrom
Conversation
paulober
force-pushed
the
fix-1690-uts-for-time-conversion-api
branch
2 times, most recently
from
ca08831 to
5263aed
Compare
paulober
changed the title
astrogeco
added
CCB:Ready
astrogeco
suggested changes
Jul 27, 2021
Contributor
astrogeco
left a comment
astrogeco
left a comment
There was a problem hiding this comment.
Hi, thanks for the contribution!
Can you change the c++ style comments // to use /* blocks?
Contributor
Author
Done... |
astrogeco
approved these changes
Jul 28, 2021
Contributor
|
@PavLL looks like you still have some checks failing, I recommend "enabling actions" in your fork. |
zanzaben
suggested changes
Jul 28, 2021
Contributor
|
CCB:2021-06-27, looking good, revisit after edits are done |
zanzaben
suggested changes
Jul 28, 2021
astrogeco
changed the title
astrogeco
changed the title
Contributor
Author
|
Ok, I just removed the TimeInRange again from the cfe_test.h header because I replaced it with CFE_Time_Compare in my ut. |
paulober
force-pushed
the
fix-1690-uts-for-time-conversion-api
branch
2 times, most recently
from
6278928 to
8274e59
Compare
Contributor
Author
|
Ok, done. I squashed the commits. |
Contributor
|
You can't use Time Compare there, that only returns -1, 0, or 1 so it passes as true only when the two times are different. You need to use time in range. |
Contributor
Author
|
Ok, I revert this. |
paulober
force-pushed
the
fix-1690-uts-for-time-conversion-api
branch
from
83d3476 to
0ea4ab8
Compare
Contributor
Author
Ok, done. I now use TimeInRange again. |
zanzaben
suggested changes
Jul 29, 2021
| /* write UTC into first buffer */ | ||
| CFE_TIME_Print(timeBuf1, UTC); | ||
|
|
||
| UtAssert_True(TimeInRange(SCTime, UTC, difference), "TAI (%s) = MET2SCTime (%s)", timeBuf1, timeBuf2); |
Contributor
There was a problem hiding this comment.
This should be UTC in the printout.
Contributor
Author
There was a problem hiding this comment.
Ok, fixed. What a stupid mistake.
paulober
force-pushed
the
fix-1690-uts-for-time-conversion-api
branch
from
0ea4ab8 to
a0a23aa
Compare
paulober
force-pushed
the
fix-1690-uts-for-time-conversion-api
branch
from
a0a23aa to
f4510c4
Compare
paulober
force-pushed
the
fix-1690-uts-for-time-conversion-api
branch
from
f4510c4 to
9e16d16
Compare
zanzaben
approved these changes
Jul 29, 2021
astrogeco
added
CCB:Approved
Contributor
|
CCB:2021-08-04 APPROVED |
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Aug 4, 2021
nasa/cFE#1742, Remove SB get last message sender info requirement nasa/cFE#1732, Fix #1725 Update UTs to use UtAssert_MIR nasa/cFE#1736, Add Functional Tests cFE Message ID nasa/cFE#1707, Add Time Conversion Functional Test
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Aug 6, 2021
**Combines** nasa/cFE#1759, v6.8.0-rc1+dev810 nasa/osal#1126, v5.1.0-rc1+dev586 **Includes** *cFE* - nasa/cFE#1752, Add null pointer check to table GetAddresses and ReleaseAddresses - nasa/cFE#1742, Remove SB get last message sender info requirement - nasa/cFE#1732, Fix #1725 Update UTs to use UtAssert_MIR - nasa/cFE#1736, Add Functional Tests cFE Message ID - nasa/cFE#1707, Add Time Conversion Functional Test - nasa/cFE#1739, Add cast to MIR prints *osal* - nasa/osal#1122, Add UtAssert_MIR macro - nasa/osal#1125, add generic asserts from CFE coverage testing - nasa/osal#1121, add osapi-shell-stubs.c to OSAL stub library Co-authored-by: Jacob Hageman <[email protected]> Co-authored-by: Joseph Hickey <[email protected]> Co-authored-by: Alex Campbell <[email protected]> Co-authored-by: Jose F Martinez Pedraza <[email protected]> Co-authored-by: Niall Mullane <[email protected]> Co-authored-by: Ariel Adams <[email protected]> Co-authored-by: Paul <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Expected behavior changes
Additional context
Hi, I'm new to this repository and tried my hand at a "good first issue". I would be very grateful if someone who knows about this repo can have a quick look and tell me if my first commit for this issue works like this. That's why the unit test is commented so much.
Thanks already :)
Contributor Info
Paul Oberosler, Individual