Fix #1650, Add File Utility Functional Tests.#1673
Merged
astrogeco merged 4 commits intonasa:integration-candidatefrom Jul 27, 2021
Merged
Fix #1650, Add File Utility Functional Tests.#1673astrogeco merged 4 commits intonasa:integration-candidatefrom
astrogeco merged 4 commits intonasa:integration-candidatefrom
Conversation
zanzaben
added
the
CCB:Ready
zanzaben
force-pushed
the
fix1650_FS_File_Util_Func_Tests
branch
from
b13bf28 to
63134bc
Compare
zanzaben
removed
the
CCB:Ready
zanzaben
commented
Jul 22, 2021
| } | ||
|
|
||
| /* FT helper stub compatible with background file write DataGetter */ | ||
| bool FS_DataGetter(void *Meta, uint32 RecordNum, void **Buffer, size_t *BufSize) |
Contributor
Author
There was a problem hiding this comment.
When these two functions exists it causes CFE_FS_InitHeader to stall, and then the test timeout detection kicks in.
Contributor
There was a problem hiding this comment.
Is this a bug or an issue w/ the test?
Contributor
|
The issue here is that we need to make sure we adhere to the API spec of the function, specifically this one: cFE/modules/core_api/fsw/inc/cfe_fs.h Lines 293 to 296 in 33a4f19 Actually I should probably correct that to say "not on stack" rather than "not on heap". I just added a delay loop to make it pass, but really should make it |
zanzaben
added
the
CCB:Ready
Contributor
zanzaben
force-pushed
the
fix1650_FS_File_Util_Func_Tests
branch
from
d045f39 to
81c598a
Compare
Contributor
skliper
approved these changes
Jul 27, 2021
Contributor
skliper
left a comment
skliper
left a comment
There was a problem hiding this comment.
Looks fine by me as long as it's working consistently as expected.
jphickey
approved these changes
Jul 27, 2021
Contributor
jphickey
left a comment
jphickey
left a comment
There was a problem hiding this comment.
Minor suggestions.... Its OK as-is I suppose, but there are few nitpicks I'd recommend improving.
jphickey
requested changes
Jul 27, 2021
jphickey
approved these changes
Jul 27, 2021
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jul 27, 2021
nasa/cFE#1673, Add File Utility Functional Tests. nasa/cFE#1711, Add custom epoch support to TIME UT
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jul 29, 2021
Combines: nasa/cFE#1701, v6.8.0-rc1+dev789 nasa/osal#1116, v5.1.0-rc1+dev578 nasa/cFS-GroundSystem#192, v2.2.0-rc1+dev58 Includes: **cFE** nasa/cFE#1699, correct return code check nasa/cFE#1700, documentation for FS APIs that return OSAL codes nasa/cFE#1695, Adding coverage tests for cfe_es_apps.c nasa/cFE#1673, Add File Utility Functional Tests. nasa/cFE#1711, Add custom epoch support to TIME UT nasa/cFE#1720, Requirements update for Caelum nasa/cFE#1721, Add null check to CFE_ES_TaskID_ToIndex. nasa/cFE#1719, scrub command documentation nasa/cFE#1715, Add time arithmetic functional tests nasa/cFE#1704, update docs for CFE_FS_BackgroundFileDumpRequest nasa/cFE#1706, correct return code mismatches **osal** nasa/osal#1114, Add unit test branch coverage **cFS-GroundSystem** nasa/cFS-GroundSystem#185, Update tlm for ES Blockstats/memstats and TBL HK nasa/cFS-GroundSystem#188, * might be referenced before assignment Co-authored-by: Jacob Hageman <[email protected]> Co-authored-by: Joseph Hickey <[email protected]> Co-authored-by: Alex Campbell <[email protected]> Co-authored-by: Jose F Martinez Pedraza <[email protected]> Co-authored-by: Niall Mullane <[email protected]> Co-authored-by: Paul <[email protected]>
astrogeco
added
CCB:Approved
Contributor
|
CCB:2021-08-04 APPROVED |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fixes #1650
Add Functional tests for File Utility Functional Tests.
Testing performed
Build and run unit test
Expected behavior changes
No impact to behavior
System(s) tested on
Ubuntu 20.04
Contributor Info - All information REQUIRED for consideration of pull request
Alex Campbell GSFC