Fix #1320 #1583 #508, Event ID updates#1594
Merged
astrogeco merged 2 commits intonasa:integration-candidatefrom Jun 23, 2021
Merged
Fix #1320 #1583 #508, Event ID updates#1594astrogeco merged 2 commits intonasa:integration-candidatefrom
astrogeco merged 2 commits intonasa:integration-candidatefrom
Conversation
skliper
added
the
CCB:Ready
Contributor
Author
|
Created draft and marked to review current approach. |
Contributor
|
CCB:2021-06-02 APPROVED
|
astrogeco
added
CCB:Approved
Contributor
Author
|
Note a future improvement could be to change how commands are documented, use grouping instead of xrefitem (cross reference) to create the group and use a |
skliper
force-pushed
the
fix1320-es_max_eid
branch
from
2047e0f to
faa68d7
Compare
skliper
force-pushed
the
fix1320-es_max_eid
branch
from
faa68d7 to
b2ed0d9
Compare
skliper
force-pushed
the
fix1320-es_max_eid
branch
from
b2ed0d9 to
82d6c39
Compare
skliper
added
the
CCB:Ready
Contributor
|
Can I remove the WIP prefix? |
skliper
changed the title
Contributor
Author
Done! |
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jun 23, 2021
nasa/cFE#1633, add test log file nasa/cFE#1594, Fix #1320 #1583 #508, Event ID updates
This was referenced Jun 23, 2021
Contributor
|
CCB:2021-06-23 APPROVED |
astrogeco
removed
the
CCB:Ready
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jun 24, 2021
*Combines* - nasa/elf2cfetbl#81 - nasa/tblCRCTool#52 - nasa/ci_lab#88 - nasa/sch_lab#83 - nasa/sample_app#150 - nasa/sample_lib#64 - nasa/to_lab#100 *Includes* - nasa/cFE#1630, correct path to users guide warning log - nasa/cFE#1621, add additional test cases for Child Tasks - nasa/cFE#1608, Add cfe functional tests to CI - nasa/cFE#1627, rename/clean CFE coverage assert macros - nasa/cFE#1623, Added UT tests for cFE ES Api - nasa/cFE#1634, Expand CDS Functional Tests. - nasa/cFE#1633, add test log file - nasa/cFE#1594, Event ID updates - nasa/cFE#1624, scrub all UT_Report calls - nasa/osal#1066, implement missing parameter/retcode test permutations - nasa/cFS-GroundSystem#182, Add test start command script for cmdUtil - nasa/tblCRCTool#51, add printf conversion casts ** Implement Coding Standard in CodeQL ** - nasa/cFS-GroundSystem#180 - nasa/elf2cfetbl#80 - nasa/tblCRCTool#49 - nasa/ci_lab#87 - nasa/sch_lab#79 - nasa/sample_app#149 - nasa/sample_lib#63 - nasa/to_lab#99
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jun 24, 2021
*Combines* - nasa/cFE#1632, v6.8.0-rc1+dev726 - nasa/osal#1079, v5.1.0-rc1+dev548 - nasa/ci_lab#88, v2.4.0-rc1+dev42 - nasa/sch_lab#83, v2.4.0-rc1+dev40 - nasa/sample_app#150, v1.2.0-rc1+dev66 - nasa/sample_lib#64, v1.2.0-rc1+dev38 - nasa/to_lab#100, v2.4.0-rc1+dev49 - nasa/elf2cfetbl#81, v3.2.0-rc1+dev30 - nasa/tblCRCTool#52, v1.2.0-rc1+dev33 - nasa/cFS-GroundSystem#183, v2.2.0-rc1+dev52 *Includes* - nasa/cFE#1630, correct path to users guide warning log - nasa/cFE#1621, add additional test cases for Child Tasks - nasa/cFE#1608, Add cfe functional tests to CI - nasa/cFE#1627, rename/clean CFE coverage assert macros - nasa/cFE#1623, Added UT tests for cFE ES Api - nasa/cFE#1634, Expand CDS Functional Tests. - nasa/cFE#1633, add test log file - nasa/cFE#1594, Event ID updates - nasa/cFE#1624, scrub all UT_Report calls - nasa/osal#1066, implement missing parameter/retcode test permutations - nasa/cFS-GroundSystem#182, Add test start command script for cmdUtil - nasa/tblCRCTool#51, add printf conversion casts ** Implement Coding Standard in CodeQL ** - nasa/cFS-GroundSystem#180 - nasa/elf2cfetbl#80 - nasa/tblCRCTool#49 - nasa/ci_lab#87 - nasa/sch_lab#79 - nasa/sample_app#149 - nasa/sample_lib#63 - nasa/to_lab#99 Co-authored-by: Jacob Hageman <[email protected]> Co-authored-by: Joseph Hickey <[email protected]> Co-authored-by: Ariel Adams <[email protected]> Co-authored-by: Alex Campbell <[email protected]> Co-authored-by: Jose F Martinez Pedraza <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #1320 - Removed CFE_ES_MAX_EID and all the others (very fragile, especially when EIDs are out of order)
Fix #1583 - Ordered EID's and fixed duplicate assignments
Fix #508 - Cleaned up EventID documentation
Testing performed
Build an run unit tests, passed - TBD (not actually done yet)
Expected behavior changes
Deconflicted EIDs.
System(s) tested on
Additional context
Did not address #1532, could be a big impact.
Wrote #1588 to track use of EID in multiple locations.
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC