Fix #1337, add docs to CFE_ES_RegisterCDS() regarding clearing#1376
Merged
astrogeco merged 1 commit intonasa:integration-candidatefrom Apr 22, 2021
Merged
Conversation
Note in the documentation for this function that it is the responsibility of the calling app to clear/fill the CDS block any time a new block is allocated.
skliper
approved these changes
Apr 19, 2021
jphickey
added
the
CCB:Ready
Contributor
|
CCB:2021-04-21 APPROVED |
astrogeco
added
CCB:Approved
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Apr 22, 2021
nasa/cFE#1290, Split interface and implementation modules nasa/cFE#1376, add docs to CFE_ES_RegisterCDS() regarding clearing
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Apr 22, 2021
Combines: nasa/cFE#1406 nasa/osal#967 nasa/cFS-GroundSystem#178 Includes: nasa/cFE#1290, Split interface and implementation modules nasa/cFE#1376, add docs to CFE_ES_RegisterCDS() regarding clearing nasa/cFE#1292, Remove testrunner and convert testcase to app cfe-IC:2021-04-20, HOTFIX: Always build cfe_assert. nasa/osal#950, Eliminate time and access name collisions with VxWorks nasa/osal#946, Fix Shell implementation on posix and rtems nasa/cFS-GroundSystem#174, update executable name and version in setup.py nasa/cFS-GroundSystem#175, Add executable install guide
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Apr 22, 2021
Combines: nasa/cFE#1406 nasa/osal#967 nasa/cFS-GroundSystem#178 Includes: nasa/cFE#1290, Split interface and implementation modules nasa/cFE#1376, add docs to CFE_ES_RegisterCDS() regarding clearing nasa/cFE#1292, Remove testrunner and convert testcase to app cfe-IC:2021-04-20, HOTFIX: Always build cfe_assert. nasa/osal#950, Eliminate time and access name collisions with VxWorks nasa/osal#946, Fix Shell implementation on posix and rtems nasa/cFS-GroundSystem#174, update executable name and version in setup.py nasa/cFS-GroundSystem#175, Add executable install guide
zanzaben
pushed a commit
to zanzaben/cFE
that referenced
this pull request
Apr 22, 2021
Fix nasa#1337, add docs to CFE_ES_RegisterCDS() regarding clearing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Note in the documentation for this function that it is the responsibility of the calling app to clear/fill the CDS block any time a new block is allocated.
Fixes #1337
Testing performed
Build and sanity check.
Expected behavior changes
None - Documentation only.
System(s) tested on
Ubuntu 20.04
Additional context
Don't recommend changing this behavior, it could easily break something or have unintended consequences, but should be clear in docs that a new CDS block must be written to before using, and it is the app/caller responsibility to do so.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.