Fix #1281, remove testrunner and convert testcase to app#1292
Merged
astrogeco merged 3 commits intonasa:integration-candidatefrom Apr 22, 2021
Merged
Fix #1281, remove testrunner and convert testcase to app#1292astrogeco merged 3 commits intonasa:integration-candidatefrom
astrogeco merged 3 commits intonasa:integration-candidatefrom
Conversation
jphickey
force-pushed
the
fix-1281-test-app
branch
from
a3007ac to
99be4cd
Compare
Contributor
Author
|
Rebased to latest mainline. |
jphickey
force-pushed
the
fix-1281-test-app
branch
from
99be4cd to
bf7f7f1
Compare
Merge the "testrunner" app and put the runner logic into cfe_assert lib. Converts the "testcase" library into an app that simply calls the logic in cfe_assert to do the test. This means that the test can be run on demand by issuing the ES start app command, rather than putting it into the startup script.
jphickey
force-pushed
the
fix-1281-test-app
branch
from
bf7f7f1 to
422dcac
Compare
jphickey
added
the
CCB:Ready
zanzaben
suggested changes
Apr 13, 2021
Contributor
zanzaben
left a comment
zanzaben
left a comment
There was a problem hiding this comment.
Need to also update cFS/cfe/docs/README_functionaltest.md file with the new instructions on how to run the tests.
Adjust the event types so that Start/End are "info" events, not debug events (in the default platform config, debug events are not shown). Also update documentation to correct the startup script entries.
Contributor
Author
Updated in ec2d2f6 |
skliper
added
CCB:2021-04-14
and removed
CCB:Ready
Contributor
|
CCB:2021-04-14 - APPROVED |
zanzaben
approved these changes
Apr 14, 2021
zanzaben
suggested changes
Apr 15, 2021
Use a constant at the top of the file, and change the names to match current environment.
jphickey
force-pushed
the
fix-1281-test-app
branch
from
e4afd35 to
23c835b
Compare
Contributor
Author
|
Corrected string checks in commit 23c835b |
zanzaben
approved these changes
Apr 20, 2021
astrogeco
added
CCB:FastTrack
CCB:Approved
astrogeco
force-pushed
the
integration-candidate
branch
from
59839e3 to
3f9f7f5
Compare
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Apr 22, 2021
nasa/cFE#1292, Remove testrunner and convert testcase to app
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Apr 22, 2021
Combines: nasa/cFE#1406 nasa/osal#967 nasa/cFS-GroundSystem#178 Includes: nasa/cFE#1290, Split interface and implementation modules nasa/cFE#1376, add docs to CFE_ES_RegisterCDS() regarding clearing nasa/cFE#1292, Remove testrunner and convert testcase to app cfe-IC:2021-04-20, HOTFIX: Always build cfe_assert. nasa/osal#950, Eliminate time and access name collisions with VxWorks nasa/osal#946, Fix Shell implementation on posix and rtems nasa/cFS-GroundSystem#174, update executable name and version in setup.py nasa/cFS-GroundSystem#175, Add executable install guide
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Apr 22, 2021
Combines: nasa/cFE#1406 nasa/osal#967 nasa/cFS-GroundSystem#178 Includes: nasa/cFE#1290, Split interface and implementation modules nasa/cFE#1376, add docs to CFE_ES_RegisterCDS() regarding clearing nasa/cFE#1292, Remove testrunner and convert testcase to app cfe-IC:2021-04-20, HOTFIX: Always build cfe_assert. nasa/osal#950, Eliminate time and access name collisions with VxWorks nasa/osal#946, Fix Shell implementation on posix and rtems nasa/cFS-GroundSystem#174, update executable name and version in setup.py nasa/cFS-GroundSystem#175, Add executable install guide
zanzaben
pushed a commit
to zanzaben/cFE
that referenced
this pull request
Apr 22, 2021
Fix nasa#1281, remove testrunner and convert testcase to app
This was referenced Jul 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
This permits tests to be invoked at any time by issuing the ES "start app" command and specifying the testcase app.
Fixes #1281
Testing performed
Build and sanity check CFE.
Run all currently-implemented functional tests
Expected behavior changes
Each functional test is a separate app, not a library, so it can be started and stopped via ES command like any other app.
System(s) tested on
Ubuntu 20.04
Additional context
Requires #1276 as prerequisite
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.