Fix #1287, split interface and implementation modules#1290
Merged
astrogeco merged 1 commit intonasa:integration-candidatefrom Apr 22, 2021
Merged
Fix #1287, split interface and implementation modules#1290astrogeco merged 1 commit intonasa:integration-candidatefrom
astrogeco merged 1 commit intonasa:integration-candidatefrom
Conversation
Separate the list of CFE core interface modules (e.g. core_api) from the list of CFE core implementation modules (e.g. msg). This allows the content of core_api to be expanded to include any additional modules the user has added to cFE core locally.
jphickey
added
the
CCB:Ready
Contributor
Author
|
Ping @excaliburtb, can you check if this patch helps your build issue? Note that if "msg" is not built directly but the replacement module still refers to code provided by "msg" - this will likely need to be updated. For instance the old "src" directory is now "fsw/src" and some of the interface is defined via core_api headers, need to make sure this isn't duplicated. |
skliper
added
CCB:2021-04-14
and removed
CCB:Ready
Contributor
|
CCB:2021-04-14 - APPROVED |
astrogeco
added
CCB:Approved
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Apr 22, 2021
nasa/cFE#1290, Split interface and implementation modules nasa/cFE#1376, add docs to CFE_ES_RegisterCDS() regarding clearing
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Apr 22, 2021
Combines: nasa/cFE#1406 nasa/osal#967 nasa/cFS-GroundSystem#178 Includes: nasa/cFE#1290, Split interface and implementation modules nasa/cFE#1376, add docs to CFE_ES_RegisterCDS() regarding clearing nasa/cFE#1292, Remove testrunner and convert testcase to app cfe-IC:2021-04-20, HOTFIX: Always build cfe_assert. nasa/osal#950, Eliminate time and access name collisions with VxWorks nasa/osal#946, Fix Shell implementation on posix and rtems nasa/cFS-GroundSystem#174, update executable name and version in setup.py nasa/cFS-GroundSystem#175, Add executable install guide
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Apr 22, 2021
Combines: nasa/cFE#1406 nasa/osal#967 nasa/cFS-GroundSystem#178 Includes: nasa/cFE#1290, Split interface and implementation modules nasa/cFE#1376, add docs to CFE_ES_RegisterCDS() regarding clearing nasa/cFE#1292, Remove testrunner and convert testcase to app cfe-IC:2021-04-20, HOTFIX: Always build cfe_assert. nasa/osal#950, Eliminate time and access name collisions with VxWorks nasa/osal#946, Fix Shell implementation on posix and rtems nasa/cFS-GroundSystem#174, update executable name and version in setup.py nasa/cFS-GroundSystem#175, Add executable install guide
zanzaben
pushed a commit
to zanzaben/cFE
that referenced
this pull request
Apr 22, 2021
Fix nasa#1287, split interface and implementation modules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Separate the list of CFE core interface modules (e.g. core_api) from the list of CFE core implementation modules (e.g. msg). This allows the content of core_api to be expanded to include any additional modules the user has added to cFE core locally.
Fixes #1287
Testing performed
Build and sanity check CFE
Run all unit tests
Expected behavior changes
No FSW change, only build system.
The "core_api" interface module will now be expanded to include anything that is in the
MISSION_CORE_MODULESlist, so if the mission has locally expanded this list, the additional/expanded content will become part ofcore_apiautomatically.System(s) tested on
Ubuntu 20.04
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.