Fix #680, Remove table service exclusion logic#1132
Merged
astrogeco merged 1 commit intonasa:integration-candidatefrom Feb 4, 2021
Merged
Fix #680, Remove table service exclusion logic#1132astrogeco merged 1 commit intonasa:integration-candidatefrom
astrogeco merged 1 commit intonasa:integration-candidatefrom
Conversation
skliper
added
the
CCB:Ready
skliper
force-pushed
the
fix680-conditional_tbl
branch
from
5120aa2 to
8257c1e
Compare
astrogeco
added
CCB:2021-01-27
and removed
CCB:Ready
Contributor
|
CCB:2021-01-27 APPROVED |
Contributor
Author
|
@astrogeco Removing the classic text startup script wasn't accepted as a change for Caelum by stakeholders. Could transition #660 to a module along side the classic method (projects could select either option at least for a while), but not a high priority (not a cert issue). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #680 - This removes the final remnants of the table service exclusion logic and documentation.
Testing performed
Build and run unit tests, passed.
Expected behavior changes
No affect to default behavior.
EXCLUDE_CFE_TBLno longer used, if define table services will still be started.System(s) tested on
Additional context
#972 will transition table service to a module that can be customized or implemented differently if desired.
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC