Skip to content

Fix #609, Remove CFE_PLATFORM_EVS_LOG_ON undefined option to diasble log#1129

Merged
astrogeco merged 1 commit intonasa:integration-candidatefrom
skliper:fix609-evs_log_not_optional
Feb 4, 2021
Merged

Fix #609, Remove CFE_PLATFORM_EVS_LOG_ON undefined option to diasble log#1129
astrogeco merged 1 commit intonasa:integration-candidatefrom
skliper:fix609-evs_log_not_optional

Conversation

@skliper
Copy link
Contributor

@skliper skliper commented Jan 25, 2021 •
edited
Loading

Describe the contribution
Fix #609 - removes the ability to disable the log by not defining CFE_PLATFORM_EVS_LOG_ON

Testing performed
Build and run unit tests, passed

Expected behavior changes
No longer able to disable log completely, for minimum memory use define CFE_PLATFORM_EVS_LOG_MAX as 1

System(s) tested on

  • Hardware: cFS Dev Server
  • OS: Ubuntu 18.04
  • Versions: Bundle main + this commit

Additional context
Could remove control based on LogEnabled, panic on reset area fail and limp along if sem create fails.
Needs requirements updates - #1131

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Jan 25, 2021
@skliper skliper added this to the 7.0.0 milestone Jan 25, 2021
@skliper skliper mentioned this pull request Jan 26, 2021
Closed
@skliper skliper force-pushed the fix609-evs_log_not_optional branch from e8fe89a to dcadb67 Compare January 27, 2021 14:33
@astrogeco astrogeco added CCB:2021-01-27 and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Jan 27, 2021
@astrogeco
Copy link
Contributor

astrogeco commented Jan 27, 2021

CCB:2021-01-27 APPROVED

  • Option to reduce memory footprint is to set max = 1
  • Keep it simple. Having cFE do this is extra complexity that might not be necessary. Let PSP work with this.

@skliper skliper marked this pull request as draft January 27, 2021 19:02
@skliper
Copy link
Contributor Author

skliper commented Jan 27, 2021

Need to remove control based on HK parameter before merge (will submit as an additional HOTFIX merge, or fasttrack?)

@astrogeco
Copy link
Contributor

astrogeco commented Feb 3, 2021

@skliper this is in draft form, can I change this to ready?

@skliper skliper mentioned this pull request Feb 4, 2021
Closed
@skliper skliper marked this pull request as ready for review February 4, 2021 12:54
@skliper
Copy link
Contributor Author

skliper commented Feb 4, 2021

@astrogeco Good to go, opened #1153 to address the CCB actions.

@astrogeco astrogeco changed the base branch from main to integration-candidate February 4, 2021 14:23
@astrogeco astrogeco merged commit 7357fa3 into nasa:integration-candidate Feb 4, 2021
@astrogeco
Copy link
Contributor

astrogeco commented Feb 4, 2021

@astrogeco Good to go, opened #1153 to address the CCB actions.

Should we address the requirements issue #1131 before merging this though?

@astrogeco
Copy link
Contributor

astrogeco commented Feb 4, 2021

@astrogeco Good to go, opened #1153 to address the CCB actions.

Should we address the requirements issue #1131 before merging this though?

Nvm, clicked merge too soon :P

astrogeco added a commit to nasa/cFS that referenced this pull request Feb 4, 2021
@astrogeco
Add cFE PRs
3a0f8cf 
nasa/cFE#1132
nasa/cFE#1129
nasa/cFE#1126
@astrogeco astrogeco mentioned this pull request Feb 15, 2021
Merged
@astrogeco astrogeco mentioned this pull request Feb 24, 2021
Merged
@skliper skliper deleted the fix609-evs_log_not_optional branch March 23, 2021 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Caelum

Development

Successfully merging this pull request may close these issues.

EVS "CFE_PLATFORM_EVS_LOG_ON" option unit test failure

2 participants

@skliper @astrogeco