Fix #915, Check for file existence in CFE_ES_RestartApp#1128
Merged
astrogeco merged 1 commit intonasa:integration-candidatefrom Feb 3, 2021
Merged
Fix #915, Check for file existence in CFE_ES_RestartApp#1128astrogeco merged 1 commit intonasa:integration-candidatefrom
astrogeco merged 1 commit intonasa:integration-candidatefrom
Conversation
skliper
added
the
CCB:Ready
This was referenced Jan 25, 2021
skliper
force-pushed
the
fix915-restart_file_check
branch
from
40d5b81 to
79c4210
Compare
astrogeco
added
CCB:2021-01-27
and removed
CCB:Ready
Contributor
|
CB:2021-01-27 APPROVED
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #915 -
CFE_ES_RestartAppnow checkes for file existence as part of command processing. Avoids removing the app if the file doesn't exist (just avoids one error case).Testing performed
Build and ran unit tests, passed. Also ran cFE and tested with valid and invalid file (moved good file), confirmed error counter increment (and command rejected so app remained running).
Expected behavior changes
Now rejects command and increments command error counter if file is missing
System(s) tested on
Additional context
#915
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC