Fix #1123, Convert global CFE_SB_Default_Qos to macro#1125
Merged
astrogeco merged 1 commit intonasa:integration-candidatefrom Feb 8, 2021
Merged
Fix #1123, Convert global CFE_SB_Default_Qos to macro#1125astrogeco merged 1 commit intonasa:integration-candidatefrom
astrogeco merged 1 commit intonasa:integration-candidatefrom
Conversation
skliper
added
CCB:Ready
skliper
force-pushed
the
fix1123-extern_qos
branch
from
c499db4 to
21fe731
Compare
Contributor
Author
|
Fixed docs in 21fe731. |
skliper
force-pushed
the
fix1123-extern_qos
branch
from
21fe731 to
7a2dcce
Compare
astrogeco
added
CCB:2021-01-27
and removed
CCB:Ready
Contributor
|
CCB:2021-01-27 APPROVED
|
Contributor
Author
|
@astrogeco fixed, I just had the base branch still at integration-candidate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #1123 - deprecates CFE_SB_Default_Qos and replaces with CFE_SB_DEFAULT_QOS macro that avoids global variable exposure, and removed SB internal defines (they aren't implemented anywhere and are not used). These can be added at the appropriate scope once requirements are defined.
Testing performed
Build and ran unit tests
Expected behavior changes
None
System(s) tested on
Additional context
@ejtimmon - deprecation of CFE_SB_Default_Qos (coding standard all-caps for macros requires change)
Depends on #1126 to compile with OMIT_DEPRECATED
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC