Fix #1069, Resolve mismatched types in SBR throttle#1116
Merged
astrogeco merged 1 commit intonasa:integration-candidatefrom Feb 3, 2021
Merged
Fix #1069, Resolve mismatched types in SBR throttle#1116astrogeco merged 1 commit intonasa:integration-candidatefrom
astrogeco merged 1 commit intonasa:integration-candidatefrom
Conversation
skliper
added
the
CCB:Ready
skliper
force-pushed
the
fix1069-sbr_throttle_types
branch
from
340a08c to
07721cb
Compare
astrogeco
added
CCB:2021-01-27
and removed
CCB:Ready
Contributor
CCB:2021-01-27 APPROVEDRemoves throttle helper function and places it in the "foreach" route ID to match types |
astrogeco
force-pushed
the
integration-candidate
branch
from
54dffe8 to
f6c6737
Compare
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Feb 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #1069 - Switched throttle indexes to use
CFE_SB_RouteId_Atom_tand combined helper function since separation no longer necessary (only 1 foreach function implemented).Testing performed
Build and run unit tests, passed.
Expected behavior changes
None, just resolves static analysis warning
System(s) tested on
Additional context
None
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC