Fix #877, Remove duplicate CFE_MISSION_REV define#1084
Merged
astrogeco merged 1 commit intonasa:integration-candidatefrom Jan 25, 2021
Merged
Conversation
skliper
added
the
CCB:Ready
astrogeco
added
CCB:2021-01-13
and removed
CCB:Ready
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jan 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #877 - removed CFE_MISSION_REV from platform config. Intent of this rev is to track mission cFE FSW mods/customization/code changes not as a more generic "MISSION" revision number.
Testing performed
Nominal build and run of unit tests
Expected behavior changes
None, although if CFE_MISSION_REV was being utilized somewhere and included from cpu1_platform_cfg.h this will break. Arguably this was broken before removal also since it was a duplicate define...
System(s) tested on
Additional context
None
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC