Fix #488, Pad msg headers to 64 bit#1077
Merged
astrogeco merged 1 commit intonasa:integration-candidatefrom Jan 25, 2021
Merged
Fix #488, Pad msg headers to 64 bit#1077astrogeco merged 1 commit intonasa:integration-candidatefrom
astrogeco merged 1 commit intonasa:integration-candidatefrom
Conversation
skliper
added
the
CCB:Ready
This was referenced Jan 7, 2021
Contributor
|
CCB:2021-01-13 APPROVED BREAKS everyone's command and telemetry. Does not violate CCSDS since this goes in the secondary header. Gets rid of implicit compiler padding. |
astrogeco
added
CCB:2021-01-13
and removed
CCB:Ready
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jan 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #488 - pads headers to 64-bit so that CFE_SB_GetUserData will work for message structures with elements up to 64 bit
Testing performed
Added #903 (to catch errors from CFE_SB_GetUserData), built unit tests for both primary only and primary + extended headers, passed.
Expected behavior changes
For primary only config - telemetry header required to 64 bit boundary (affects all receivers)
For primary + extended config - command header required padding to 64 bit boundary (affects all senders)
System(s) tested on
Additional context
Will require updates in cFS-GroundSystem, both cmdUtil, and cmd/tlm from the GUI
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC