Merged
Conversation
Contributor
Author
|
@skliper Th following unit test seems to be hanging with OMIT_DEPRECATED = true Start 57: select-test |
Contributor
|
@astrogeco There is a race in main right now, any test run might hang. See nasa/osal#721. Just requested that one get fast-tracked... |
Contributor
|
Yes- I can confirm this is the exact symptom of the race condition that is fixed by nasa/osal#721. It was in the previous build too (main branch) it is just that it doesn't get triggered with every run, so it wasn't noticed. |
Fix #1064, Add cppcheck GitHub Actions workflow
astrogeco
force-pushed
the
integration-candidate
branch
from
fbd4d8a to
de0052a
Compare
Also update Readme.md
astrogeco
force-pushed
the
integration-candidate
branch
from
95364b8 to
42ca5f9
Compare
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jan 7, 2021
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jan 7, 2021
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jan 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #1054, Resolve osal guide generation warnings
Fix #1059, Corrects documentation for CFE_SB_GetPipeName() stub
Fix #1064, Add cppcheck GitHub Actions workflow
Testing performed
Github Actions Run https://github.com/nasa/cFS/pull/172/checks
Expected behavior changes
PR #1056 - Resolved doxygen warnings osalguide and updated header file references
PR #1060 - Corrects the documentation for the
CFE_SB_GetPipeName()unit test stub function.PR #1065 - Adds a new github actions workflow file to run cppcheck
System(s) tested on
Ubuntu 18.04
Additional context
Part of nasa/cFS#172
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
@astrogeco
@CDKnightNASA
@skliper