Fix #1023, correct stub appid parameter#1024
Merged
astrogeco merged 1 commit intonasa:integration-candidatefrom Dec 1, 2020
Merged
Fix #1023, correct stub appid parameter#1024astrogeco merged 1 commit intonasa:integration-candidatefrom
astrogeco merged 1 commit intonasa:integration-candidatefrom
Conversation
The type of this should be CFE_ES_ResourceID_t, not uint32
jphickey
added
the
CCB:Ready
Contributor
|
CCB 2020-11-18 APPROVED |
astrogeco
added
IC-20201124
and removed
CCB:Ready
astrogeco
added a commit
to astrogeco/cFS
that referenced
this pull request
Dec 1, 2020
astrogeco
added a commit
to astrogeco/cFS
that referenced
this pull request
Dec 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
The type of the AppID parameter on Cleanup routines should be
CFE_ES_ResourceID_t, notuint32Fixes #1023
Testing performed
Build and run CFE
Run all unit tests
Expected behavior changes
None.
System(s) tested on
Ubuntu 20.04
Additional context
These two are typedef equivalent in the main branch, so no change, but needed for consistency. This was missed originally due to PR #1012 not being there yet.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.