Fix #1016, bogus warning in strncpy#1018
Merged
astrogeco merged 1 commit intonasa:integration-candidatefrom Dec 1, 2020
Merged
Fix #1016, bogus warning in strncpy#1018astrogeco merged 1 commit intonasa:integration-candidatefrom
astrogeco merged 1 commit intonasa:integration-candidatefrom
Conversation
Add an extra write of a null char which squelches a warning.
jphickey
added
the
CCB:Ready
Contributor
Author
|
@astrogeco , @skliper -- given that this is a trivial one liner that fixes a compiler warning - it might be worth fast tracking into the next baseline. |
skliper
approved these changes
Nov 16, 2020
Contributor
|
CCB 2020-11-18 APPROVED |
astrogeco
approved these changes
Nov 23, 2020
astrogeco
added
IC-20201124
and removed
CCB:Ready
astrogeco
added a commit
to astrogeco/cFS
that referenced
this pull request
Dec 1, 2020
astrogeco
added a commit
to astrogeco/cFS
that referenced
this pull request
Dec 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Add an extra write of a null char which squelches a warning.
Fixes #1016
Testing performed
Build and sanity check CFE with BUILDTYPE=release on focal
Expected behavior changes
None - just avoid extraneous warning
System(s) tested on
Ubuntu 20.04
Additional context
Buffer was already zero'ed out via previous memset, so this extra zero really has no effect except (possibly) using an extra CPU cycle. This just appeases some over-zealous compiler warning logic.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.