Is your feature request related to a problem? Please describe.
Prototype defined in both cFE and OSAL.
|
/*****************************************************************************/ |
|
/** |
|
** \brief Report and close any sockets found open |
|
** |
|
** \par Description |
|
** Determine if any sockets are open; if so, close them. If UT_VERBOSE |
|
** is defined then output the socket status to the test log file. |
|
** |
|
** \par Assumptions, External Events, and Notes: |
|
** None |
|
** |
|
** \returns |
|
** This function does not return a value. |
|
** |
|
******************************************************************************/ |
|
void UT_CheckForOpenSockets(void); |
https://github.com/nasa/osal/blob/f12d42ba58837a645d05eda3479d5f613ebad6c4/src/ut-stubs/utstub-helpers.h#L111-L115
Implemented here:
https://github.com/nasa/osal/blob/f12d42ba58837a645d05eda3479d5f613ebad6c4/src/ut-stubs/utstub-helpers.c#L195-L217
Also violation of magic number use in the implementation, and doesn't seem to actually do what it says (I don't see the close).
Describe the solution you'd like
Maybe remove if not useful? If not, at least use the correctly scoped prototype and remove the second definition.
Describe alternatives you've considered
None.
Additional context
None
Requester Info
Jacob Hageman - NASA/GSFC
