CFE_SB_GetLastSenderID returns pointer to internal data, possible race

**Describe the bug**
CFE_SB_GetLastSenderID returns pointer to data that could be overwritten at any time

See https://github.com/nasa/cFE/pull/605#discussion_r407649126 for related comments

**To Reproduce**
Conceptually - app calls CFE_SB_GetLastSenderID, gets pointer, data gets overwritten, app takes action based on overwritten data vs original context

**Expected behavior**
No race.

**Code snips**
https://github.com/nasa/cFE/blob/60a5f6580d1e737f46efce0418aba5b8dac6df6a/fsw/cfe-core/src/sb/cfe_sb_api.c#L1651-L1657

**System observed on:**
N/A

**Additional context**
#605

**Reporter Info**
Jacob Hageman

	/* Get ptr to buffer descriptor for the last msg received on the given pipe */
	Ptr2BufDescriptor = CFE_SB.PipeTbl[PipeId].CurrentBuff;

	/* Set the receivers pointer to the adr of 'Sender' struct in buf descriptor */
	Ptr = (CFE_SB_SenderId_t ) &Ptr2BufDescriptor -> Sender;

	CFE_SB_UnlockSharedData(__func__,__LINE__);

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CFE_SB_GetLastSenderID returns pointer to internal data, possible race #608

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

CFE_SB_GetLastSenderID returns pointer to internal data, possible race #608

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions