-
Notifications
You must be signed in to change notification settings - Fork 236
Description
Is your feature request related to a problem? Please describe.
Expectation is to use defaults unless there's a requirement/justification to have custom limits. There is neither for the code snips below, and no clear reason why the default limits aren't good enough (they should be fine).
cFE/fsw/cfe-core/src/es/cfe_es_task.c
Lines 281 to 285 in c7363c8
| /* | |
| ** Subscribe to Housekeeping request commands | |
| */ | |
| Status = CFE_SB_SubscribeEx(CFE_SB_ValueToMsgId(CFE_ES_SEND_HK_MID), CFE_ES_TaskData.CmdPipe, | |
| CFE_SB_Default_Qos, CFE_ES_TaskData.LimitHK); |
cFE/fsw/cfe-core/src/es/cfe_es_task.c
Lines 292 to 296 in c7363c8
| /* | |
| ** Subscribe to ES task ground command packets | |
| */ | |
| Status = CFE_SB_SubscribeEx(CFE_SB_ValueToMsgId(CFE_ES_CMD_MID), CFE_ES_TaskData.CmdPipe, | |
| CFE_SB_Default_Qos, CFE_ES_TaskData.LimitCmd); |
cFE/fsw/cfe-core/src/evs/cfe_evs_task.c
Lines 318 to 320 in c7363c8
| /* Subscribe to command and telemetry requests coming in on the command pipe */ | |
| Status = CFE_SB_SubscribeEx(CFE_SB_ValueToMsgId(CFE_EVS_CMD_MID), CFE_EVS_GlobalData.EVS_CommandPipe, | |
| CFE_SB_Default_Qos, CFE_EVS_MSG_LIMIT); |
cFE/fsw/cfe-core/src/evs/cfe_evs_task.c
Lines 327 to 328 in c7363c8
| Status = CFE_SB_SubscribeEx(CFE_SB_ValueToMsgId(CFE_EVS_SEND_HK_MID), CFE_EVS_GlobalData.EVS_CommandPipe, | |
| CFE_SB_Default_Qos, CFE_EVS_MSG_LIMIT); |
Note for all but 1 case, the message limit value set is the same as the default (4).
Describe the solution you'd like
Either justify these differences or just use the default subscribe call.
Describe alternatives you've considered
None
Additional context
None
Requester Info
Jacob Hageman - NASA/GSFC