Merged
Conversation
cfe_psp_version.c should have been included in the source list, but was mistakenly omitted in previous PR.
Fix #277, add version file
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #277, add version file
Fix #275, Adds a UT stub for CFE_PSP_GetKernelTextSegmentInfo
Testing
psp tests https://github.com/nasa/PSP/pull/279/checks
bundle tests https://github.com/nasa/cFS/pull/227/checks
Expected behavior changes
PR #278
Includes
cfe_psp_version.cin the cmake source list, which was mistakenly omitted previously.PR #276
Applied the patch and confirmed that CS Cmake unit tests build. Unit tests relying on
CFE_PSP_GetKernelTextSegmentInfowill build.Additional Context
Part of nasa/cFS#227
Authors
@ejtimmon
@jphickey