Fix #261, add psp_module_api interface target#262
Merged
Conversation
jphickey
added
the
CCB:Ready
skliper
reviewed
Mar 9, 2021
jphickey
force-pushed
the
fix-261-psp-api-intf
branch
from
18f7164 to
147ac40
Compare
Adds a new target for PSP modules and use this to propagate the compile definitions and include directories for all PSP code.
jphickey
force-pushed
the
fix-261-psp-api-intf
branch
from
147ac40 to
0ccebed
Compare
Contributor
Author
|
Cleaned up another bit of debug stuff. Also noticed in doing this that we have a conflict with the "eeprom" stuff - the stuff in |
astrogeco
added
CCB:FastTrack
and removed
CCB:Ready
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Mar 11, 2021
astrogeco
added a commit
to astrogeco/cFS
that referenced
this pull request
Mar 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Adds a new target for PSP modules and use this to propagate the compile definitions and include directories for all PSP code.
This is basically analogous to the
core_privateinterface library provided by CFE, but for PSP code. It is used by PSP internal components and extensions. The public/external PSP API is still provided by the interface properties on the normal (static) PSP library.Fixes #261
Testing performed
Build and sanity check CFE
run all unit tests
Expected behavior changes
No impact to behavior (build system change only)
System(s) tested on
Ubuntu 20.04
Additional context
nasa/cFE#1203 will also require this.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.