Fix #126, Refactor CFE_PSP_ModuleType_t enum#235
Fix #126, Refactor CFE_PSP_ModuleType_t enum#235astrogeco merged 1 commit intonasa:integration-candidatefrom
Conversation
skliper
added
the
CCB:Ready
|
CCB:2021-01-13 CHANGE Invalid should stay zero. |
astrogeco
added
CCB:2021-01-13
and removed
CCB:Ready
Avoids irregular enum warning
skliper
force-pushed
the
fix126-irregular_enum
branch
from
97284ee to
c8dcf56
Compare
|
Updated/simplified... could evolve to a switch or whatever if extended, but behavior is the same w/ just a simple equality check at this point. |
jphickey
left a comment
jphickey
left a comment
There was a problem hiding this comment.
This is fine.
Just a note that the reason there was a "range" instead of just a single value it was intended to have more than one, it just ended up that the "SIMPLE" was the only module type that made it into the common framework code. For instance there are some old projects I did where we had two types, "SIMPLE" and "DEVICE_DRIVER" - the latter provided a useful layer to abstract our low level device I/O on a per-platform basis - but this type isn't in the common framework now, of course. But probably a "switch" would be better there anyway.
3 participants
Describe the contribution
Fix #126 - Avoids irregular enum warning
Testing performed
Build bundle and unit test (passed)
Expected behavior changes
None other than eliminates static analysis warning
System(s) tested on
Additional context
None
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC