Merged
Conversation
Integration Candidate 2020-11-24
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Dec 3, 2020
Combines nasa/cFE#1027 nasa/osal#662 nasa/PSP#221 nasa/sample_app#113 nasa/sample_lib#38 nasa/sch_lab#58 nasa/tblCRCTool#25 Co-authored-by: Joseph Hickey <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #214, Refactoring UT_SetForceFail to UT_SetDefaultReturnValue
Fix #217, use size_t in PSP stubs
Testing performed
See events for "github actions test" at https://github.com/astrogeco/cFS/actions
Expected behavior changes
PR #215 - Rename
UT_SetForceFailtoUT_SetDefaultReturnValuesince some functions that retain more than 1 value are not necessarily failing.PR #219 - Use of the size_t type instead of uint32 in unit-tests to avoid a compiler type mismatch error on some platforms.
System(s) tested on
Ubuntu 18.04
Additional context
Part of nasa/cFS#158
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
@zanzaben
@jphickey