Conversation
Improve the module ID lookup when getting the CFE core text segment info. - Ideally get the ID directly from what was loaded by startCfeCore - As a fallback use the actual CFE core name from the configdata Do not use a hardcoded name.
Fix #111, do not assume a specific core name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #111
Testing performed
Bundle CI: https://github.com/nasa/cFS/pull/152/checks
Expected behavior changes
PR #207 - Improves the module ID lookup when getting the CFE core text segment info. VxWorks PSP should use the real module name, not assume cfe-core.o when getting text segment info
System(s) tested on
Ubuntu CI
Additional context
Part of nasa/cFS#152
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request