Fix #187, Set stub spacecraft ID to historical value (0x42)#188
Merged
astrogeco merged 1 commit intonasa:1.5.xfrom Sep 3, 2020
Merged
Fix #187, Set stub spacecraft ID to historical value (0x42)#188astrogeco merged 1 commit intonasa:1.5.xfrom
astrogeco merged 1 commit intonasa:1.5.xfrom
Conversation
skliper
added
enhancement
Contributor
|
@skliper should this one go into Bootes as well? |
astrogeco
added
IC-20200826
and removed
CCB:Ready
Contributor
Author
|
I support adding it to Bootes. Consistency is good. |
Contributor
|
Instructions to merge into both
|
Contributor
Author
|
Can I rebase this feature branch on 1.4.x and update the base of this PR to 1.4.x, then open a new PR for main (w/ the same feature branch)? |
Contributor
|
I think that might work as well. That essentially combines steps (1), (2), and (3) I think. |
Contributor
Author
|
Oh, as it shows here this is already based on 1.5.x, so I think 1) 2) and 4) are covered. I'll try to open a PR for 3). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #187 - set the stub config data spacecraft id to historical value 0x42, was 42.
Testing performed
Nominal build/test, passed.
Expected behavior changes
Anything using the stub config data will now get the default. The point is really to reduce confusion the mismatch could cause. Nothing should actually be using this stub data directly.
System(s) tested on
Additional context
nasa/cFE#828
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC