Skip to content

Fix #216, #227 - Adds strict cppcheck and fixes remaining warnings (replace codec macros)#228

Merged
astrogeco merged 2 commits intonasa:mainfrom
skliper:fix216-strict_cppcheck
Apr 19, 2022
Merged

Fix #216, #227 - Adds strict cppcheck and fixes remaining warnings (replace codec macros)#228
astrogeco merged 2 commits intonasa:mainfrom
skliper:fix216-strict_cppcheck

Conversation

@skliper
Copy link

@skliper skliper commented Apr 8, 2022 •
edited
Loading

Checklist (Please check before submitting)

Describe the contribution

Testing performed
Build/run unit tests, also manually ran strict cppcheck on fsw/

Expected behavior changes
None except now enforcing strict cppcheck in CI

System(s) tested on

  • Hardware: i5/wsl
  • OS: Ubuntu 18.04
  • Versions: Bundle main + this commit

Additional context
Workflow will fail until #226 is merged since one of the warnings were fixed there.
Also will fail until nasa/cFS#454 is merged based on the directory fix

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Apr 8, 2022
@skliper skliper added this to the Draco milestone Apr 8, 2022
This was referenced Apr 8, 2022
Merged
Merged
@astrogeco astrogeco removed the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Apr 13, 2022
@astrogeco
Copy link
Contributor

astrogeco commented Apr 13, 2022

CCB:2022-04-13 APPROVED

astrogeco added a commit to astrogeco/CF that referenced this pull request Apr 18, 2022
@astrogeco
Merge pull request nasa#228 from skliper/fix216-strict_cppcheck
683812d 
Fix nasa#216, nasa#227 - Adds strict cppcheck and fixes remaining warnings (replace codec macros)

- HOTFIX nasa#228, remove `/` prefix to fsw from strict-dir-list input
astrogeco added a commit to astrogeco/CF that referenced this pull request Apr 18, 2022
@astrogeco
Merge pull request nasa#228 from skliper/fix216-strict_cppcheck
9233e7c 
Fix nasa#216, nasa#227 - Adds strict cppcheck and fixes remaining warnings (replace codec macros)

- HOTFIX nasa#228-1, remove `/` prefix to fsw from strict-dir-list input
- HOTFIX nasa#228-2, fix cppcheck warning for declaration-definition name
mismatch of `CF_CFDP_DecodeCrc` argument-2
@astrogeco
Copy link
Contributor

astrogeco commented Apr 18, 2022 •
edited
Loading

Resolved conflict and added hotfixes to fix cppcheck error quoted below. See fix in astrogeco@96cdf30

[fsw/src/cf_codec.h:821] -> [fsw/src/cf_codec.c:1050]: (style, inconclusive) Function 'CF_CFDP_DecodeCrc' argument 2 names different: declaration 'pcrc' definition 'plcrc'.
Error: Process completed with exit code 255.

astrogeco added a commit to astrogeco/CF that referenced this pull request Apr 19, 2022
@astrogeco
Merge pull request nasa#228 from skliper/fix216-strict_cppcheck
f954ee4 
Fix nasa#216, nasa#227 - Adds strict cppcheck and fixes remaining warnings (replace codec macros)

- HOTFIX nasa#228-2, fix cppcheck warning for declaration-definition name
mismatch of `CF_CFDP_DecodeCrc` argument-2
@astrogeco astrogeco merged commit 96cdf30 into nasa:main Apr 19, 2022
@skliper skliper mentioned this pull request May 24, 2022
Closed
3 tasks
@skliper skliper deleted the fix216-strict_cppcheck branch June 10, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CCB:Approved dependency draco-rc2

Projects

None yet

Milestone

v7.0.0

2 participants

@skliper @astrogeco