Fix #93, Adds format check and static analysis workflows#205
Merged
Fix #93, Adds format check and static analysis workflows#205
Conversation
|
What happened to the format check? It's OK that it fails, we can submit a merge to fix once the other merges are in. |
Contributor
Author
|
@skliper The format check failed on the "Error on differences" step from within the script. According to github actions, the process exited with error code 255 in this step after it identified failure in files primarily from the unit-test repo, but also a few from the fsw repo. |
astrogeco
changed the title
astrogeco
changed the title
Contributor
|
It might have to do with the clang-format version differences that Joe mentioned in #93 |
Contributor
|
@chillfig looks like the second commit deleted the format check workflow |
chillfig
force-pushed
the
cf_add_workflow
branch
from
d98e216 to
0ed0e26
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Fixes #93
Testing performed
Tested format check on fork: https://github.com/chillfig/CF/runs/5662467104?check_suite_focus=true
Tested static analysis on fork: https://github.com/chillfig/CF/runs/5662467266?check_suite_focus=true
Expected behavior changes
Passing workflow
System(s) tested on
Ubuntu 18.04
Additional context
The added format check workflow catches a format check error when it runs its "error on differences" step. Specifically, the workflow throws errors on the placement of "*" with pointer variables written in the fsw and unit test files. The format check would rather that "*" be on the left side of the whitespace than the right side.
Contributor Info - All information REQUIRED for consideration of pull request
Justin Figueroa, ASRC Federal