Skip to content

Comments

Convert JS variables to JSON file#6

Merged
narze merged 4 commits intonarze:mainfrom
fResult:fResult/js-to-json
Oct 20, 2023
Merged

Convert JS variables to JSON file#6
narze merged 4 commits intonarze:mainfrom
fResult:fResult/js-to-json

Conversation

@fResult
Copy link
Contributor

@fResult fResult commented Oct 14, 2023

Issue #4 krub

@vercel
Copy link

vercel bot commented Oct 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
resume ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2023 6:11pm

@fResult fResult changed the title Convert JS variable to JSON files #4 Convert JS variable to JSON files Oct 14, 2023
@fResult fResult changed the title #4 Convert JS variable to JSON files narze#4 Convert JS variable to JSON files Oct 14, 2023
@fResult fResult changed the title narze#4 Convert JS variable to JSON files Convert JS variable to JSON files Oct 14, 2023
@narze
Copy link
Owner

narze commented Oct 16, 2023

That's neat!

By the way I think only 1 json file should be enough with nested format e.g.

{
  "intro": { ... },
  "projects": [ ... ],
  ...
}

This way it'll be easier to load and export data in the future

@fResult
Copy link
Contributor Author

fResult commented Oct 16, 2023

That's neat!

By the way I think only 1 json file should be enough with nested format e.g.

{
  "intro": { ... },
  "projects": [ ... ],
  ...
}

This way it'll be easier to load and export data in the future

Fixed krub.
I'm not sure this is correct yet.
Please don't hesitate to suggest this to be better.

@fResult fResult force-pushed the fResult/js-to-json branch from 55395e6 to 4c9a991 Compare October 16, 2023 10:11
@fResult fResult changed the title Convert JS variable to JSON files Convert JS variables to JSON file Oct 16, 2023
@fResult
Copy link
Contributor Author

fResult commented Oct 17, 2023

Already fixed krub 😀

Copy link
Owner

@narze narze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💖

@narze narze merged commit 782dca4 into narze:main Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants