feat(target): add support for x86_64-pc-windows-gnu #2935
Conversation
How to use the Graphite Merge QueueAdd the label ready-to-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
|
@Brooooooklyn When it passes, i would like to know if it is possible for me to test this PR on my device in some way, please let me know. |
lsq
force-pushed
the
x86_64-pc-windows-gnu
branch
from
e2bd38e to
610fad2
Compare
|
cursor review |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the x86_64-pc-windows-gnu target to enable Node.js applications built with GNU toolchain on Windows. The change addresses multiple related issues in the ecosystem where MINGW/MSYS2 environments were not properly supported.
- Adds x86_64-pc-windows-gnu to the list of available targets
- Updates runtime detection logic to distinguish between MSVC and GNU toolchains on Windows
- Includes the new target in GitHub Actions filtering for macOS and Windows targets
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cli/src/utils/target.ts | Adds x86_64-pc-windows-gnu to AVAILABLE_TARGETS array |
| cli/src/utils/tests/snapshots/target.spec.ts.md | Updates test snapshot to include new target configuration |
| cli/src/api/templates/js-binding.ts | Adds runtime detection for MINGW32_NT to load appropriate GNU bindings |
| cli/src/api/new.ts | Includes new target in macOSAndWindowsTargets set for GitHub Actions filtering |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
lsq
force-pushed
the
x86_64-pc-windows-gnu
branch
3 times, most recently
from
b1c72df to
a9f16ff
Compare
lsq
force-pushed
the
x86_64-pc-windows-gnu
branch
from
a9f16ff to
c519c1c
Compare
2 participants
Description
Supports node built with GNU toolschain in windows.
Relevant issue numbers:
resolves 2934
resolves vitejs/vite#20550
resolves msys2/MINGW-packages#20407
resolves rollup/rollup#5439
resolves rollup/rollup#6059