fix(cli): use new URL instead of ?url for browser wasm fetching#2511
Closed
hi-ogawa wants to merge 2 commits intonapi-rs:mainfrom
Closed
fix(cli): use new URL instead of ?url for browser wasm fetching#2511hi-ogawa wants to merge 2 commits intonapi-rs:mainfrom
new URL instead of ?url for browser wasm fetching#2511hi-ogawa wants to merge 2 commits intonapi-rs:mainfrom
Conversation
Brooooooklyn
approved these changes
Mar 18, 2025
Contributor
Author
|
As I wrote in #2517 (comment), this change would require Vite users to add |
Member
|
Hmmmm, I think making the Vite user experience silky smooth is the primary goal |
Brooooooklyn
force-pushed
the
main
branch
3 times, most recently
from
de8b925 to
9896876
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related vitejs/vite#19639, oxc-project/oxc#9783
Closes #2517
I was testing napi-rs oxc-parser package on browser (see sample app in oxc-project/oxc#9783) and noticed that
?urlis causing some issues on Vite. Usingnew URLworks around the issue and also I think it's better to avoid?urlsince it requires a special bundler side convention.I just saw the comment on oxc-project/playground#67 (comment) and the example on https://github.com/napi-rs/node-rs-playground/ and this change might not be so simple. Let me double check what's the difference there.