fix(napi): handle nul byte in object key#2385
Merged
Brooooooklyn merged 7 commits intonapi-rs:mainfrom Dec 3, 2024
Merged
Conversation
Brooooooklyn
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NulError of CString while creating javascript object #2110I added nul safe handling to
JsObject::setandget. This covers map conversion used in rolldown.I initially only fixed map conversion, but I moved the same logic to
JsObject7751530 since the underlying issue is there. I'm not sure about the perf impact of extranapi_create_string_utf8call on each get/set.