Improve widget clean up in test_widget_hide_destroy#6741
Merged
jni merged 1 commit intonapari:mainfrom Apr 15, 2024
Merged
Conversation
Contributor
Author
lucyleeow
changed the title
test_widget_hide_destroy
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6741 +/- ##
==========================================
- Coverage 92.34% 92.29% -0.05%
==========================================
Files 613 613
Lines 54713 54716 +3
==========================================
- Hits 50525 50502 -23
- Misses 4188 4214 +26 ☔ View full report in Codecov by Sentry. |
Contributor
|
@Czaki I suggested to Lucy that these be added back because I thought when we destroy the enclosing |
Contributor
Author
|
ping @Czaki |
jni
approved these changes
Apr 12, 2024
Czaki
approved these changes
Apr 12, 2024
github-actions
Bot
removed
the
ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References and relevant issues
Follow on from #4991
see: #4991 (comment)
Description
Better naming in
test_widget_hide_destroyAdds more widget clean up steps. The tests passes fine currently but Draga suggested it was best to add these back.