Fix npe1 samples menu building#6739
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6739 +/- ##
==========================================
- Coverage 92.34% 92.29% -0.05%
==========================================
Files 613 613
Lines 54713 54713
==========================================
- Hits 50525 50499 -26
- Misses 4188 4214 +26 ☔ View full report in Codecov by Sentry. |
Czaki
left a comment
Czaki
left a comment
There was a problem hiding this comment.
looks ok. Waiting on @DragaDoncila manual testing
| stack=False, | ||
| ) | ||
| _add_sample_partial = partial( | ||
| _add_sample, |
There was a problem hiding this comment.
Where add sample is defined? It is function used currently by npe2?
There was a problem hiding this comment.
Yeah, the callback is the same for npe1 and npe2 for samples
DragaDoncila
left a comment
DragaDoncila
left a comment
There was a problem hiding this comment.
Tested with two npe1 plugins in env, both providing one or multiple samples, both URI and command based. Everything looks good to me. Thanks @lucyleeow!
|
Adding ready-to-merge for this one. @Czaki feel free to remove if you need more time. |
DragaDoncila
added
the
ready to merge
|
I just miss your review... |
4 participants
References and relevant issues
Follows on from #4991
Description
partialfor the npe1 sample menu buildunregisterlist, so actions are correct when plugin status is changed.