feat(container): data-drive global CLI installs from cli-tools.json#2758
Merged
Conversation
The agent's global Node CLIs (claude-code, agent-browser, vercel) were each
a hardcoded ARG + RUN layer in the Dockerfile, so adding or bumping one meant
editing the Dockerfile — a code reach-in every tool-installing skill had to make.
Move the tool list into container/cli-tools.json. A skill now adds a CLI by
appending a {name, version} entry (a json-merge) — the safest change shape:
deterministic, idempotent, removable. install-cli-tools.sh parses the manifest
with node (no new jq dep), writes the per-tool only-built-dependencies opt-ins,
and runs one pinned `pnpm install -g`, so the pnpm supply-chain path is unchanged.
Behavior is byte-for-byte: same opt-ins, same pinned installs. agent-browser is
now pinned (0.27.1, what `latest` last resolved to) instead of floating.
container/cli-tools.test.ts guards the seam: red if a baseline tool is dropped,
a version unpins, or the Dockerfile wiring / pnpm path is removed.
Co-Authored-By: Claude Opus 4.8 <[email protected]>
This was referenced Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The agent's global Node CLIs (
claude-code,agent-browser,vercel) now install from a data manifest —container/cli-tools.json— instead of hardcodedARG+RUNblocks in the Dockerfile.A skill that needs a CLI tool now adds a
{ "name", "version" }row (a json-merge) — the safest change shape: deterministic, idempotent, removable — instead of reaching into the Dockerfile. This is the first "core the hotspot" seam: the ~10 tool-installing skills' Dockerfile edits collapse to a manifest append.How
container/cli-tools.json— the tool list.container/install-cli-tools.sh— parses the manifest withnode(no newjqdependency), writes the per-toolonly-built-dependenciesopt-ins into/root/.npmrc, then runs one pinnedpnpm install -g. Every install stays on the pnpm path, so the supply-chain policy is unchanged.container/Dockerfile— threeARGs + threeRUNlayers →COPY+ oneRUN.container/cli-tools.test.ts+vitest.config.ts— guard: red if a baseline tool is dropped, a version unpins, or the Dockerfile/pnpm wiring is removed.Notes
only-built-dependenciesopt-ins and identical pinned install specs (verified by reproducing the install command set from the manifest).agent-browserpinned to0.27.1(whatlatestlast resolved to) — removes the one floating version, and the test now enforces exact-semver pins for every entry.--mount=type=cachepnpm store keeps re-installs fast.Validation
./container/build.shend-to-end not yet completed on the authoring machine (intermittent connectivity blocked the apt layer); the change sits below that layer and the install mechanism is proven equivalent. A green CI image build before merge is the remaining check.🤖 Generated with Claude Code