Repository navigation
fix(ci): revert setup-node v5→v4 to fix npm publish 404 - #213
Merged
Merged
Conversation
PR #212 bumped setup-node@v4 → @v5 while fixing the tag scheme. With setup-node@v5, npm 11.x auto-detects an OIDC trusted-publishing context even when only classic NPM_TOKEN auth is configured, and surfaces the result as a misleading 404 from PUT /@nano-step%2fnano-brain. Evidence: - v2026.5.2902 (setup-node@v4) → published OK on May 29 - v2026.5.30.1/.2/.3 (setup-node@v5) → 404 (broken tag scheme + v5) - v2026.5.3001 (setup-node@v5, valid tag) → still 404, tag is valid Upstream issues confirming the regression: - actions/setup-node#1551 — v5 writes _authToken line that breaks OIDC - actions/setup-node#1445 — Trusted Publisher 404 with NODE_AUTH_TOKEN - npm/cli#8730 — npm 11.x OIDC publish surfaces as E404 Fix is the minimum diff: pin setup-node@v4, drop the always-auth: false line (only needed for v5's deprecated warning), add a comment so the next maintainer doesn't innocently bump it again. Republish path (manual, follow-up): 1. Delete tag + GitHub release for v2026.5.3001 2. Re-push v2026.5.3001 onto the new master HEAD 3. release.yml fires with the v4 fix → npm publish should succeed
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
4 tasks done
1 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #212 fixed the tag scheme but accidentally bumped
actions/setup-node@v4→@v5. With v5, npm 11.x auto-detects an OIDC trusted-publishing context even when only classicNPM_TOKENauth is configured, and surfaces the failure as a misleading 404 fromPUT /@nano-step%2fnano-brain.Result: every CI publish since May 30 has failed at the
npm-publishjob — including the otherwise-correctv2026.5.3001(binaries + GH release exist, only npm publish failed).Evidence
Upstream issues confirming the regression:
_authTokenline that breaks OIDCChange
Surgical revert.
always-auth: falseis removed because it only existed to silence a v5-only deprecation warning.Follow-up (manual, after merge)
v2026.5.3001(binaries can stay or be re-uploaded by the workflow)v2026.5.3001onto the new master HEADrelease.ymlre-fires with the v4 fix →npm publishshould succeednpm view @nano-step/[email protected]andnpm view [email protected]Validation
go build ./...— unaffected (workflow-only change)Change type:
infrastructure(CI). No new test required, validation is the nextrelease.ymlrun.