Repository navigation
Commit 6f5dcfe
[astropy#5408] Add regression test and fix for astropy#5408
I had to rework how Card._verify works: Normally the run_option method,
when passed a fix= argument, runs the fix code immediately. However,
the fix code can have side-effects that modify the behavior of the
later verifications, which makes reasoning about _verify very difficult.
So I changed it so that it first collects a list of errors (and
potentially errors to fix) and then runs the fixes collectively at the
end. It would probably be better if that were the way verify() worked
in general, but that is a larger refactoring job to leave for later
(possibly can wait until astropy#3668).1 parent 97106ca commit 6f5dcfe
2 files changed
Lines changed: 56 additions & 25 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1068 | 1068 | | |
1069 | 1069 | | |
1070 | 1070 | | |
1071 | | - | |
1072 | | - | |
1073 | | - | |
| 1071 | + | |
1074 | 1072 | | |
1075 | 1073 | | |
1076 | 1074 | | |
1077 | 1075 | | |
1078 | 1076 | | |
1079 | | - | |
| 1077 | + | |
1080 | 1078 | | |
1081 | 1079 | | |
1082 | 1080 | | |
1083 | 1081 | | |
1084 | 1082 | | |
1085 | | - | |
1086 | | - | |
| 1083 | + | |
1087 | 1084 | | |
1088 | 1085 | | |
1089 | 1086 | | |
| |||
1102 | 1099 | | |
1103 | 1100 | | |
1104 | 1101 | | |
1105 | | - | |
1106 | | - | |
| 1102 | + | |
1107 | 1103 | | |
1108 | 1104 | | |
1109 | 1105 | | |
| |||
1113 | 1109 | | |
1114 | 1110 | | |
1115 | 1111 | | |
1116 | | - | |
1117 | | - | |
| 1112 | + | |
1118 | 1113 | | |
1119 | 1114 | | |
1120 | 1115 | | |
| |||
1124 | 1119 | | |
1125 | 1120 | | |
1126 | 1121 | | |
1127 | | - | |
1128 | | - | |
| 1122 | + | |
1129 | 1123 | | |
1130 | 1124 | | |
1131 | 1125 | | |
1132 | 1126 | | |
1133 | 1127 | | |
1134 | | - | |
1135 | | - | |
1136 | | - | |
1137 | | - | |
1138 | | - | |
1139 | | - | |
1140 | | - | |
1141 | | - | |
| 1128 | + | |
| 1129 | + | |
| 1130 | + | |
| 1131 | + | |
| 1132 | + | |
| 1133 | + | |
| 1134 | + | |
| 1135 | + | |
| 1136 | + | |
| 1137 | + | |
| 1138 | + | |
| 1139 | + | |
1142 | 1140 | | |
1143 | 1141 | | |
1144 | 1142 | | |
1145 | 1143 | | |
1146 | 1144 | | |
1147 | 1145 | | |
1148 | 1146 | | |
1149 | | - | |
1150 | | - | |
1151 | | - | |
1152 | | - | |
1153 | | - | |
| 1147 | + | |
| 1148 | + | |
| 1149 | + | |
| 1150 | + | |
1154 | 1151 | | |
1155 | 1152 | | |
| 1153 | + | |
| 1154 | + | |
1156 | 1155 | | |
1157 | 1156 | | |
1158 | 1157 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2398 | 2398 | | |
2399 | 2399 | | |
2400 | 2400 | | |
| 2401 | + | |
| 2402 | + | |
| 2403 | + | |
| 2404 | + | |
| 2405 | + | |
| 2406 | + | |
| 2407 | + | |
| 2408 | + | |
| 2409 | + | |
| 2410 | + | |
| 2411 | + | |
| 2412 | + | |
| 2413 | + | |
| 2414 | + | |
| 2415 | + | |
| 2416 | + | |
| 2417 | + | |
| 2418 | + | |
| 2419 | + | |
| 2420 | + | |
| 2421 | + | |
| 2422 | + | |
| 2423 | + | |
| 2424 | + | |
| 2425 | + | |
| 2426 | + | |
| 2427 | + | |
| 2428 | + | |
| 2429 | + | |
| 2430 | + | |
| 2431 | + | |
| 2432 | + | |
2401 | 2433 | | |
2402 | 2434 | | |
2403 | 2435 | | |
| |||
0 commit comments