Add option do drop new tasks to the timeline from an external component#941
Merged
Ilaiwi merged 21 commits intonamespace-ee:masterfrom Jan 16, 2025
Merged
Add option do drop new tasks to the timeline from an external component#941Ilaiwi merged 21 commits intonamespace-ee:masterfrom
Ilaiwi merged 21 commits intonamespace-ee:masterfrom
Conversation
Ensure all children of defaultitemrenderer do have a unique key pass ref to the item added explicit border styles to avoid warning
# Conflicts: # package.json
Collaborator
|
Great job! I had an example long time ago that does this but I couldn't find it. I will take a closer look tomorrow morning and merge. |
|
@Ilaiwi Is there an ETA for when this PR gets merged/next beta is released? Would love to have the stylesheet fix for my nextjs project. |
Ilaiwi
approved these changes
Jan 16, 2025
Ilaiwi
approved these changes
Jan 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request proposes a solution for #940
We suggest a table (to the right) containing draggable elements. These can be dropped onto the timeline canvas.
Since rct already uses interactjs, why not use that to reach this goal?
Overview of PR
All logic on what to drop at which moment is allowed, is up to the user via the interact configuration.
The library needs to expose some callbacks in order to be able to calculate where the new item is dropped.
Also #939 is fixed with this PR, so no bundled stylesheet anymore.
And basic demo with nextjs 15 is added.
Don't forget to update the CHANGELOG.md file with any changes that are in this PR