Skip to content

Disable auto monkeypatch v3#728

Merged
mattbennett merged 6 commits intonameko:v3.0.0-rcfrom
mattbennett:disable-auto-monkeypatch-v3
Oct 13, 2021
Merged

Disable auto monkeypatch v3#728
mattbennett merged 6 commits intonameko:v3.0.0-rcfrom
mattbennett:disable-auto-monkeypatch-v3

Conversation

@mattbennett
Copy link
Copy Markdown
Member

Equivalent to #727, for v3 branch

(resolves nameko#703)

* warns users if the monkeypatch is not applied
* suggests using pytest-eventlet as an alternative

# Conflicts:
#	nameko/testing/pytest.py
+ update warning
+ move nameko run patch into cli so it is earlier and more explicit
@mattbennett mattbennett force-pushed the disable-auto-monkeypatch-v3 branch from 70e0570 to 45dcc07 Compare October 11, 2021 12:39
@mattbennett mattbennett force-pushed the disable-auto-monkeypatch-v3 branch from 45dcc07 to 6b7cc4e Compare October 11, 2021 12:43
Copy link
Copy Markdown
Contributor

@iky iky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mattbennett mattbennett merged commit c3f09c1 into nameko:v3.0.0-rc Oct 13, 2021
@mattbennett mattbennett deleted the disable-auto-monkeypatch-v3 branch October 13, 2021 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants