remove automatic monkey-patching#727
Merged
mattbennett merged 8 commits intonameko:masterfrom Oct 13, 2021
Merged
Conversation
(resolves nameko#703) * warns users if the monkeypatch is not applied * suggests using pytest-eventlet as an alternative
+ update warning + move nameko run patch into cli so it is earlier and more explicit
mattbennett
force-pushed
the
disable-auto-monkeypatch
branch
from
b03bb55 to
d72e851
Compare
mattbennett
force-pushed
the
disable-auto-monkeypatch
branch
from
e4f56e9 to
5a5e135
Compare
iky
approved these changes
Oct 12, 2021
Contributor
iky
left a comment
iky
left a comment
There was a problem hiding this comment.
Resolves #703
- warns users if the monkeypatch is not applied
- suggests using pytest-eventlet as an alternative
To complete the change description one bit is missing:
- adds
nameko testcommand which wraps pytest, automatically applies eventlet monkeypatch before invoking pytest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #703
nameko testcommand which wraps pytest, automatically applies eventlet monkeypatch before invoking pytestnameko testor thepytest-eventletplugin as an alternative