Require snmpgetnext to build check_snmp #802
Open
+18
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not strictly required here, but the AS_IF macro is generally safer because it handles (often unintentional) AC_REQUIRE calls.
PATH_TO_SNMPGETNEXT is used unconditionally in plugins/check_snmp.c, and the build will fail if it is left undefined (that is, if we are building check_snmp but snmpgetnext was neither found on the user's PATH or supplied manually). To avoid this build failure, we now test for snmpgetnext inside the case for snmpget, and skip check_snmp unless BOTH are found. Closes nagios-pluginsGH-788
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
configure.acperforms checks for two programs,The second one is used by
check_snmponly when a particular flag is passed, but in reality,snmpgetnextis still required because unless itsPATH_TO_SNMPGETNEXTis defined, compilation ofcheck_snmp.cwill fail.I have no idea how you might wind up with
snmpgetand notsnmpgetnext, but at least one person has managed to do it and file a Gentoo bug about it. To fix the issue, this PR will disable the building ofcheck_snmpifsnmpgetnextis missing. It also emits a warning in that case.Closes: