Skip to content

feat(cli): add --no-open flag to preview and play commands #1

Closed

Description

@na-navi

Problem

hyperframes preview and hyperframes play always open the system default browser on startup.

This is problematic for agent-driven workflows where the browser session is managed separately.

Proposed Solution

Add --no-open flag to both commands. Default false, preserving existing behavior.

Scope

  • preview.ts — guard all 4 import("open") calls
  • play.ts — guard the import("open") call

Branch

feat-preview-no-open — 2 files, ready for PR to upstream.

Activity

  1. na-navi commented on May 15, 2026

    @na-navi
    OwnerAuthor

    実装状況

    feat-preview-no-open ブランチにコミット済み。

    変更ファイル

    • packages/cli/src/commands/preview.ts — --no-open arg 定義 + 4箇所の import("open") にガード追加
    • packages/cli/src/commands/play.ts — --no-open arg 定義 + 1箇所の import("open") にガード追加

    CI

    • lefthook pre-commit: lint ✅ format ✅ typecheck ✅
    • commitlint ✅

    テスト

    ローカルでの動作確認中。bun run build 後に dist/cli.js 内5箇所の import("open") 全てにガードがあることを確認済み。

    レビューお願いします。問題なければクローズします。

  2. added a commit that references this issue on May 15, 2026
    e843401
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions