Skip to content

Make wrapSchema generic. Fix #3064#1

Merged
n1ru4l merged 1 commit inton1ru4l:typescript-strictfrom
AugustinLF:make-wrapschema-generic
Jun 11, 2021
Merged

Make wrapSchema generic. Fix #3064#1
n1ru4l merged 1 commit inton1ru4l:typescript-strictfrom
AugustinLF:make-wrapschema-generic

Conversation

@AugustinLF
Copy link
Copy Markdown

As suggested in the issue #3064, here's a PR to make wrapSchema generic.

@n1ru4l n1ru4l merged commit 321e8ca into n1ru4l:typescript-strict Jun 11, 2021
@AugustinLF AugustinLF deleted the make-wrapschema-generic branch June 11, 2021 07:27
@AugustinLF
Copy link
Copy Markdown
Author

Thanks!

@n1ru4l
Copy link
Copy Markdown
Owner

n1ru4l commented Jun 11, 2021

@AugustinLF We try to merge an release the stuff soon :)

ardatan pushed a commit that referenced this pull request Jun 21, 2021
n1ru4l added a commit that referenced this pull request Jul 15, 2021
* enable noImplicitThis

* enable `strictBindCallApply`

* enable `strictFunctionTypes` 1: testing

* enable `strictFunctionTypes` 2: utils

* enable strictFunctionTypes 3: schema

* enable strictFunctionTypes 4: batch-execute

* enable strictFunctionTypes 5 `load`

* enable strictFunctionTypes 6 `loaders/url`

* enable strictFunctionTypes 7 `webpack-loader`

* enable strictFunctionTypes 8 `links`

* enable strictFunctionTypes 9 `delegate` and `batch-delegate`

* enable `strictFunctionTypes` 10 `wrap`

* enable `strictFunctionTypes` 11 `stitch` and `stitching-directive`

* enable `strictFunctionTypes` final tsconfig

* remove unnecessary generic params

* enable `strictNullChecks` 1 `utils`

* enable `strictNullChecks` 2 `schema`

* enable `strictNullChecks` 3 `resolvers-composition`

* enable `strictNullChecks` 4 `webpack-loader`

* enable `strictNullChecks` 5 `batch-execute`

* enable `strictNullChecks` 6 `graphql-tag-plug`

* enable `strictNullChecks` 7 `import`

* enable `strictNullChecks` 8 `loaders/url`

* enable `strictNullChecks` 8 `loaders/prisma`

* enable `strictNullChecks` 8 `loaders/module`

* enable `strictNullChecks` 9 `loaders/github`

* enable `strictNullChecks` 12 `loaders/code-file`

* enable `strictNullChecks` 13 `load`

* enable `strictNullChecks` 14 `delegate`

* enable `strictNullChecks` 15 `batch-delegate`

* interlude: move commonly used stuff to testing folder

* enable `strictNullChecks` 16 `wrap`

* enable `strictNullChecks` 17 `stitch`

* enable `strictNullChecks` 18 `load-files`

* enable `strictNullChecks` 19 `load-typedefs`

* enable `strictNullChecks` 20 `merge`

* enable `strictNullChecks` 21 `node-require`

* enable `strictNullChecks` 22 `mock`

* enable `strictNullChecks` 22 `stitching-directive`

* enable `strictNullChecks` flag in tsconfig

* fix: graphql-js 14 compat

* fix `strictPropertyInitialization` errors

* enable strictPropertyInitialization rule

* strict mode!!!

* enable `noPropertyAccessFromIndexSignature`

* enable `noFallthroughCasesInSwitch` and `noPropertyAccessFromIndexSignature`

* Add strict to new changes

* fix: remove casts as upstream issue is fixed

* fix: throw if we cannot identify the operation type.

ardatan#3010 (comment)
ardatan#3010 (comment)

* fix: change wording of error

ardatan#3010 (comment)

* fix: make error message more clear

ardatan#3010 (comment)

* refactor: use null/undefined instead of falsey check

* fix: assert operation from document

ardatan#3010 (comment)

* fix: type narrowing not working due to generics

ardatan#3010 (comment)

* fix: apply feedback for relocateError

* Make wrapSchema generic. Fix ardatan#3064 (#1)

* Fix Build

Co-authored-by: Arda TANRIKULU <[email protected]>
Co-authored-by: Augustin Le Fèvre <[email protected]>
n1ru4l pushed a commit that referenced this pull request Aug 19, 2021
API routes generation fix

docs & components update; routing fixes

gitignore update

fix(deps): update dependency extract-files to v11 (ardatan#3065)

Co-authored-by: Renovate Bot <[email protected]>

fix(deps): update dependency tslib to ~2.3.0 (ardatan#3067)

Co-authored-by: Renovate Bot <[email protected]>

fix(deps): update dependency the-guild-components to v1.3.1 (ardatan#3070)

Co-authored-by: Renovate Bot <[email protected]>

fix(deps): update dependency apollo-upload-client to v16 (ardatan#3066)

Co-authored-by: Renovate Bot <[email protected]>

chore(deps): update typescript-eslint monorepo to v4.27.0 (ardatan#3071)

Co-authored-by: Renovate Bot <[email protected]>

chore(deps): update babel monorepo to v7.14.6 (ardatan#3072)

Co-authored-by: Renovate Bot <[email protected]>

[deploy_website] Update generate-schema.md (ardatan#3074)

corrected grammar

fix(deps): update dependency globby to v11.0.4 (ardatan#3077)

Co-authored-by: Renovate Bot <[email protected]>

fix(deps): update dependency ws to v7.5.0 (ardatan#3078)

Co-authored-by: Renovate Bot <[email protected]>

chore(deps): update dependency typescript to v4.3.3 (ardatan#3083)

Co-authored-by: Renovate Bot <[email protected]>

chore(deps): update dependency typedoc to v0.20.37 (ardatan#3082)

Co-authored-by: Renovate Bot <[email protected]>

Jest Transformer for GraphQL (ardatan#1887)

* Jest Transformer for GraphQL

* Changeset

* Align versions

* Fix package.json

* yarn.lock

* Fix

Co-authored-by: Arda TANRIKULU <[email protected]>

chore(deps): update dependency @types/ws to v7.4.5 (ardatan#3084)

Co-authored-by: Renovate Bot <[email protected]>

Safer use of `Object.prototype.hasOwnProperty` (ardatan#3069)

* Safer use of `Object.prototype.hasOwnProperty`

Fixes an error I get when GraphQL JS passes a prototypeless object into the resolver

```
ReferenceError: maybeRef is not defined
    at eval (eval at <anonymous> (/Users/mattalexander/Projects/edge-sites-schema/tests/regression.test.js:67:7), <anonymous>:1:38)
    at forEach (/projectpath/tests/regression.test.js:67:7)
    at Array.forEach (<anonymous>)
    at Object.<anonymous> (/projectpath/tests/regression.test.js:65:17)
```

* changeset and test

Co-authored-by: Arda TANRIKULU <[email protected]>

BugFix: Handle parsing endpoints when there are no mutations (ardatan#3076)

* BugFix: Handle parsing endpoints when there are no mutations

* changeset and test

* pass tests

Co-authored-by: itai <[email protected]>
Co-authored-by: Arda TANRIKULU <[email protected]>

chore(deps): update dependency typescript to v4.3.4 (ardatan#3086)

Co-authored-by: Renovate Bot <[email protected]>

chore(deps): update dependency typedoc to v0.21.0 (ardatan#3087)

Co-authored-by: Renovate Bot <[email protected]>

chore(deps): update dependency typedoc-plugin-markdown to v3.10.0 (ardatan#3088)

Co-authored-by: Renovate Bot <[email protected]>

chore(deps): update dependency eslint to v7.29.0 (ardatan#3089)

Co-authored-by: Renovate Bot <[email protected]>

chore(deps): update dependency graphql to v15.5.1 (ardatan#3091)

Co-authored-by: Renovate Bot <[email protected]>

enable typescript strict mode (ardatan#3010)

* enable noImplicitThis

* enable `strictBindCallApply`

* enable `strictFunctionTypes` 1: testing

* enable `strictFunctionTypes` 2: utils

* enable strictFunctionTypes 3: schema

* enable strictFunctionTypes 4: batch-execute

* enable strictFunctionTypes 5 `load`

* enable strictFunctionTypes 6 `loaders/url`

* enable strictFunctionTypes 7 `webpack-loader`

* enable strictFunctionTypes 8 `links`

* enable strictFunctionTypes 9 `delegate` and `batch-delegate`

* enable `strictFunctionTypes` 10 `wrap`

* enable `strictFunctionTypes` 11 `stitch` and `stitching-directive`

* enable `strictFunctionTypes` final tsconfig

* remove unnecessary generic params

* enable `strictNullChecks` 1 `utils`

* enable `strictNullChecks` 2 `schema`

* enable `strictNullChecks` 3 `resolvers-composition`

* enable `strictNullChecks` 4 `webpack-loader`

* enable `strictNullChecks` 5 `batch-execute`

* enable `strictNullChecks` 6 `graphql-tag-plug`

* enable `strictNullChecks` 7 `import`

* enable `strictNullChecks` 8 `loaders/url`

* enable `strictNullChecks` 8 `loaders/prisma`

* enable `strictNullChecks` 8 `loaders/module`

* enable `strictNullChecks` 9 `loaders/github`

* enable `strictNullChecks` 12 `loaders/code-file`

* enable `strictNullChecks` 13 `load`

* enable `strictNullChecks` 14 `delegate`

* enable `strictNullChecks` 15 `batch-delegate`

* interlude: move commonly used stuff to testing folder

* enable `strictNullChecks` 16 `wrap`

* enable `strictNullChecks` 17 `stitch`

* enable `strictNullChecks` 18 `load-files`

* enable `strictNullChecks` 19 `load-typedefs`

* enable `strictNullChecks` 20 `merge`

* enable `strictNullChecks` 21 `node-require`

* enable `strictNullChecks` 22 `mock`

* enable `strictNullChecks` 22 `stitching-directive`

* enable `strictNullChecks` flag in tsconfig

* fix: graphql-js 14 compat

* fix `strictPropertyInitialization` errors

* enable strictPropertyInitialization rule

* strict mode!!!

* enable `noPropertyAccessFromIndexSignature`

* enable `noFallthroughCasesInSwitch` and `noPropertyAccessFromIndexSignature`

* Add strict to new changes

* fix: remove casts as upstream issue is fixed

* fix: throw if we cannot identify the operation type.

ardatan#3010 (comment)
ardatan#3010 (comment)

* fix: change wording of error

ardatan#3010 (comment)

* fix: make error message more clear

ardatan#3010 (comment)

* refactor: use null/undefined instead of falsey check

* fix: assert operation from document

ardatan#3010 (comment)

* fix: type narrowing not working due to generics

ardatan#3010 (comment)

* fix: apply feedback for relocateError

* Make wrapSchema generic. Fix ardatan#3064 (#1)

* Fix Build

Co-authored-by: Arda TANRIKULU <[email protected]>
Co-authored-by: Augustin Le Fèvre <[email protected]>

Huge cleanup before major release (breaking) (ardatan#3081)

* Breaking cleanup before major release

* Fix TS

* More

chore(deps): update typescript-eslint monorepo to v4.28.0 (ardatan#3093)

Co-authored-by: Renovate Bot <[email protected]>

fix(deps): update babel monorepo to v7.14.7 (ardatan#3094)

Co-authored-by: Renovate Bot <[email protected]>

chore(deps): update jest monorepo to v27.0.5 (ardatan#3095)

Co-authored-by: Renovate Bot <[email protected]>

chore(deps): update dependency @vue/compiler-sfc to v3.1.2 (ardatan#3097)

Co-authored-by: Renovate Bot <[email protected]>

fix build errors

Huge cleanup before major release (breaking) (ardatan#3081)

* Breaking cleanup before major release

* Fix TS

* More

chore(deps): update typescript-eslint monorepo to v4.28.0 (ardatan#3093)

Co-authored-by: Renovate Bot <[email protected]>

fix(deps): update babel monorepo to v7.14.7 (ardatan#3094)

Co-authored-by: Renovate Bot <[email protected]>

chore(deps): update jest monorepo to v27.0.5 (ardatan#3095)

Co-authored-by: Renovate Bot <[email protected]>

chore(deps): update dependency @vue/compiler-sfc to v3.1.2 (ardatan#3097)

Co-authored-by: Renovate Bot <[email protected]>

fix(deps): update dependency the-guild-components to v1.4.0 (ardatan#3098)

Co-authored-by: Renovate Bot <[email protected]>

chore(deps): update dependency @types/node to v14.17.4 (ardatan#3101)

Co-authored-by: Renovate Bot <[email protected]>

Some other refactor (ardatan#3096)

* Fix typing errors in tests

* ReplaObject.keys/values and forEach with for..in and for..of loops

* Improve Type Checking

* Update CI workflow

* Fix linting

* Fix TS errors for v14

* More

* More

* Allow incremental builds

* Finish

* Fix Type Check

* Disable sourcemaps

* Fix type issues

Better changelog

Respect  and  in  and more changes

chore(CI): Ability to release canaries on demand

Make AggregateError spec compliant

reintegration

docs update

updated tgc version and removed Poppins import

Able to release with custom tags

chore(deps): update dependency typedoc-plugin-markdown to v3.10.2 (ardatan#3107)

Co-authored-by: Renovate Bot <[email protected]>

Prevent TS Server to die on VSCode

chore(deps): update dependency typedoc to v0.21.1 (ardatan#3108)

Co-authored-by: Renovate Bot <[email protected]>

chore(deps): update dependency graphql-tag to v2.12.5 (ardatan#3109)

Co-authored-by: Renovate Bot <[email protected]>

chore(deps): update dependency prettier to v2.3.2 (ardatan#3110)

Co-authored-by: Renovate Bot <[email protected]>

chore(deps): update dependency typedoc to v0.21.2 (ardatan#3111)

Co-authored-by: Renovate Bot <[email protected]>

chore(deps): update dependency @types/babel__traverse to v7.14.0 (ardatan#3112)

Co-authored-by: Renovate Bot <[email protected]>

chore(deps): update jest monorepo to v27.0.6 (ardatan#3115)

Co-authored-by: Renovate Bot <[email protected]>

Remove Subscriber and use only Executor (ardatan#3117)

* Remove Subscriber and use only Executor

* Fix introspectSchema

* Fix tests

* Cleanup

fix(deps): update dependency ws to v7.5.1 (ardatan#3118)

Co-authored-by: Renovate Bot <[email protected]>

enhance(url-loader): refactor

Fix rawSDL issue

enhance(delegate): skip validation by default and add validateRequest option to enable

chore(deps): update dependency typescript to v4.3.5 (ardatan#3122)

Co-authored-by: Renovate Bot <[email protected]>

fix(file-loader): location path must be normalized (ardatan#3121)

chore(deps): update dependency husky to v7 (ardatan#3123)

Co-authored-by: Renovate Bot <[email protected]>

feat(graphql-tag-pluck): keep locationOffset and return graphql-js Source instead of string

chore(deps): update dependency @vue/compiler-sfc to v3.1.3 (ardatan#3125)

Co-authored-by: Renovate Bot <[email protected]>

chore(deps): update dependency @vue/compiler-sfc to v3.1.4 (ardatan#3126)

Co-authored-by: Renovate Bot <[email protected]>

fix(deps): update dependency @types/websocket to v1.0.3 (ardatan#3129)

Co-authored-by: Renovate Bot <[email protected]>

chore(deps): update dependency @types/ws to v7.4.6 (ardatan#3128)

Co-authored-by: Renovate Bot <[email protected]>

chore(deps): update dependency eslint to v7.30.0 (ardatan#3130)

Co-authored-by: Renovate Bot <[email protected]>

fix(deps): update dependency ws to v7.5.2 (ardatan#3131)

Co-authored-by: Renovate Bot <[email protected]>

fix(url-loader): fix node support for EventSource

feat(resolvers-composition): add support for glob patterns (ardatan#3132)

* feat(resolvers-composition): add support for glob patterns

* fix(resolvers-composition): add typings for micromatch

* feat(resolvers-composition): add unit tests for glob patterns

* chore(resolver-compositions): cleanup

* feat(docs): added samples for resolver composition path matcher format

* chore: added changeset

* fix(docs): typo

* fix(changeset): change patch to minor

* Fix tests and cleanup

Co-authored-by: Arda TANRIKULU <[email protected]>

chore(deps): pin dependency @types/micromatch to 4.0.1 (ardatan#3133)

Co-authored-by: Renovate Bot <[email protected]>

chore(deps): update dependency nock to v13.1.1 (ardatan#3134)

Co-authored-by: Renovate Bot <[email protected]>

don't throw on errors that should not be relocated (ardatan#3136)

refactor: internal StitchingInfo properties (ardatan#3137)

to never be undefined

docs update

docs update after review

Some fixes

update tgc version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants