download_url should point to the public url#1
Merged
Conversation
repository_download_file is manager only view whereas repository_file_download is public view. Updating the download url so that OAI and JATS metadata contain correct url for repository item.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
repository_download_file is a manager only view whereas repository_file_download is a public view. Updating the download url so that OAI and JATS metadata contain correct public url for repository item. The download_url is used in OAI and JATS templates as well as in some emails. If the emails need to have manager only url, we can add additional download_url method in model to serve manager-only url.