🐛 fix isParenthesized() check on CatchClause.param (#16)

fisker · web-flow · commit b8820bc40243 · 2021-05-14T11:12:50.000+09:00
diff --git a/src/is-parenthesized.js b/src/is-parenthesized.js
@@ -92,7 +92,11 @@ export function isParenthesized(
         sourceCode = nodeOrSourceCode
     }
 
-    if (node == null) {
+    if (
+        node == null ||
+        // `CatchClause.param` can't be parenthesized, example `try {} catch (error) {}`
+        (node.parent.type === "CatchClause" && node.parent.param === node)
+    ) {
         return false
     }
 
diff --git a/test/is-parenthesized.js b/test/is-parenthesized.js
@@ -203,6 +203,12 @@ describe("The 'isParenthesized' function", () => {
                 "body.0.object": true,
             },
         },
+        {
+            code: "try {} catch (a) {}",
+            expected: {
+                "body.0.handler.param": false,
+            },
+        },
     ]) {
         describe(`on the code \`${code}\``, () => {
             for (const key of Object.keys(expected)) {

Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,11 @@ export function isParenthesized(`
`92`	`92`	`sourceCode = nodeOrSourceCode`
`93`	`93`	`}`
`94`	`94`
`95`		`- if (node == null) {`
	`95`	`+ if (`
	`96`	`+ node == null \|\|`
	`97`	+ // `CatchClause.param` can't be parenthesized, example `try {} catch (error) {}`
	`98`	`+ (node.parent.type === "CatchClause" && node.parent.param === node)`
	`99`	`+ ) {`
`96`	`100`	`return false`
`97`	`101`	`}`
`98`	`102`