no-unsupported-features: Use semver public API's.#99
Merged
mysticatea merged 1 commit intomysticatea:masterfrom Dec 7, 2017
coreyfarrell:semver-public-api
Merged
no-unsupported-features: Use semver public API's.#99mysticatea merged 1 commit intomysticatea:masterfrom coreyfarrell:semver-public-api
mysticatea merged 1 commit intomysticatea:masterfrom
coreyfarrell:semver-public-api
Conversation
Add a '<' before the minimum version of features to make semver range representing all versions that do not support the feature. Add '>=' before the version if provided through options to produce a semver range. If the two ranges intersect then report use of an unsupported feature.
Codecov Report
@@ Coverage Diff @@
## master #99 +/- ##
==========================================
+ Coverage 98.44% 98.52% +0.07%
==========================================
Files 42 42
Lines 1029 1014 -15
==========================================
- Hits 1013 999 -14
+ Misses 16 15 -1
Continue to review full report at Codecov.
|
Owner
|
Oh, nice patch! |
Contributor
Author
|
I think semver.intersects is brand new. The first build attempt failed because I didn't change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch makes the minimum changes needed to remove all use of undocumented semver API's so it can be unpinned. This results in a slight change to the error message generated when package.json contains engines.node. We no longer calculate the lowest supported version so the message now contains the sanitized semver range string insead of a single version.