use is-core-module@^2.3.0 to support node: scheme#277
Merged
sosukesuzuki merged 1 commit intomysticatea:masterfrom Jun 1, 2021
Merged
use is-core-module@^2.3.0 to support node: scheme#277sosukesuzuki merged 1 commit intomysticatea:masterfrom
sosukesuzuki merged 1 commit intomysticatea:masterfrom
Conversation
Collaborator
As requested in mysticatea#275, recognize Node.js core modules referenced using the [`node:`](https://nodejs.org/api/esm.html#esm_node_imports) URL scheme. Since `resolve.isCore` was moved to `is-core-module` in browserify/resolve@7c26483 and `[email protected]` added support for `node:` in inspect-js/is-core-module@7341223 require `is-core-module@^2.3.0`. Note: `is-core-module` checks whether the module is supported in a given Node.js version (if not provided, the current version is checked). Although checking whether a name is a core module in all Node.js versions supported by the package would be ideal, it will require significantly more design and implementation work and is therefore not included in this commit. Fixes: mysticatea#275 Signed-off-by: Kevin Locke <[email protected]>
kevinoid
force-pushed
the
support-node-scheme
branch
from
2b59338 to
18327ed
Compare
Contributor
Author
Yes indeed. Thanks @sosukesuzuki, good catch! Fixed and rebased on current |
sosukesuzuki
approved these changes
Jun 1, 2021
|
Hello, when can we expect this to be published? Thanks in advance cc: @sosukesuzuki |
brettz9
pushed a commit
to brettz9/eslint-plugin-node
that referenced
this pull request
Jul 24, 2024
…ticatea#277) * fix: Remove "node:" prefix from "no-unsupported-features/node-builtins" message * docs: Remove enumeration in docs for no-unsupported-features/node-builtins * chore: Remove accidental `gi` * Update docs/rules/no-unsupported-features/node-builtins.md Co-authored-by: Sebastian Good <[email protected]> --------- Co-authored-by: 唯然 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested in #275, recognize Node.js core modules referenced using the node: URL scheme.
Since
resolve.isCorewas moved tois-core-modulein browserify/resolve@7c26483 and[email protected]added support fornode:in inspect-js/is-core-module@7341223 requireis-core-module@^2.3.0.Note:
is-core-modulechecks whether the module is supported in a given Node.js version (if not provided, the current version is checked). Although checking whether a name is a core module in all Node.js versions supported by the package would be ideal, it will require significantly more design and implementation work and is therefore not included in this commit.Fixes: #275
Thanks for considering,
Kevin