Update: add ESLint core Node.js and CommonJS rules#206
Merged
mysticatea merged 12 commits intomysticatea:masterfrom Feb 18, 2020
Merged
Update: add ESLint core Node.js and CommonJS rules#206mysticatea merged 12 commits intomysticatea:masterfrom
mysticatea merged 12 commits intomysticatea:masterfrom
Conversation
kaicataldo
commented
Feb 10, 2020
kaicataldo
force-pushed
the
deprectea-core-node-rules
branch
from
ae6f2be to
be2442c
Compare
kaicataldo
commented
Feb 10, 2020
This was referenced Feb 10, 2020
mysticatea
requested changes
Feb 11, 2020
Owner
mysticatea
left a comment
mysticatea
left a comment
There was a problem hiding this comment.
Thank you very much for working on this!
Almost LGTM, but I have a few requests.
kaicataldo
commented
Feb 11, 2020
kaicataldo
force-pushed
the
deprectea-core-node-rules
branch
from
f93ba69 to
ae4e32a
Compare
Author
|
Anything else you need from me to land this? |
Owner
|
Thank you for your work! I will land this next weekend. |
brettz9
pushed a commit
to brettz9/eslint-plugin-node
that referenced
this pull request
Jul 24, 2024
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in eslint/eslint#12835, this PR ports over ESLint's core Node.js and CommonJS rules to this plugin. I've tried to follow the style I see in this repo, but please let me know if I missed anything. Thanks!
Questions: