Skip to content

fix dynamic import#201

Merged
mysticatea merged 1 commit intomysticatea:masterfrom
fisker:fix-no-missing-import
Dec 23, 2019
Merged

fix dynamic import#201
mysticatea merged 1 commit intomysticatea:masterfrom
fisker:fix-no-missing-import

Conversation

@fisker
Copy link
Copy Markdown
Contributor

@fisker fisker commented Dec 23, 2019

fixes: #200

mysticatea
mysticatea approved these changes Dec 23, 2019
View reviewed changes
Copy link
Copy Markdown
Owner

@mysticatea mysticatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you so much!

@mysticatea mysticatea merged commit 4f74fbf into mysticatea:master Dec 23, 2019
@fisker fisker deleted the fix-no-missing-import branch December 23, 2019 11:27
@ehmicky
Copy link
Copy Markdown

ehmicky commented Dec 25, 2019

Would it be possible to make a release @mysticatea?
Thanks @fisker and @mysticatea for this PR.

@mysticatea
Copy link
Copy Markdown
Owner

mysticatea commented Dec 26, 2019

I have published: https://github.com/mysticatea/eslint-plugin-node/releases/tag/v11.0.0

@ehmicky
Copy link
Copy Markdown

ehmicky commented Jan 6, 2020

Thanks a lot @mysticatea!

@aldeed aldeed mentioned this pull request Apr 7, 2020
Open
@pagarwal-ignitetech
Copy link
Copy Markdown

pagarwal-ignitetech commented Aug 16, 2021

This bug still exist in latest v11.1.0 of eslint-plugin-node for no-duplicate-case and few others

" --> stderr: TypeError: Cannot read property 'indexOf' of undefined"
Error
2021-08-16 08:59:05.500 IST
finder-job-df4b88
" --> stderr: Occurred while linting /tmp/github.com/trilogy-group/alpha-coach-bot/data/amplify/backend/function/importCommonLitData/src/index.ts:2"
Error
2021-08-16 08:59:05.500 IST
finder-job-df4b88
" --> stderr: at stripImportPathParams (/node_modules/eslint-plugin-node/lib/util/strip-import-path-params.js:8:20)"
Error
2021-08-16 08:59:05.500 IST
finder-job-df4b88
" --> stderr: at ExportAllDeclaration,ExportNamedDeclaration,ImportDeclaration,ImportExpression (/node_modules/eslint-plugin-node/lib/util/visit-import.js:55:40)"
Error
2021-08-16 08:59:05.500 IST
finder-job-df4b88
" --> stderr: at /node_modules/eslint/lib/linter/safe-emitter.js:45:58"
Error
2021-08-16 08:59:05.500 IST
finder-job-df4b88
" --> stderr: at Array.forEach (<anonymous>)"
Error
2021-08-16 08:59:05.500 IST
finder-job-df4b88
" --> stderr: at Object.emit (/node_modules/eslint/lib/linter/safe-emitter.js:45:38)"
Error
2021-08-16 08:59:05.500 IST
finder-job-df4b88
" --> stderr: at NodeEventGenerator.applySelector (/node_modules/eslint/lib/linter/node-event-generator.js:256:26)"
Error
2021-08-16 08:59:05.500 IST
finder-job-df4b88
" --> stderr: at NodeEventGenerator.applySelectors (/node_modules/eslint/lib/linter/node-event-generator.js:285:22)"

brettz9 pushed a commit to brettz9/eslint-plugin-node that referenced this pull request Jul 24, 2024
@github-actions
chore(master): release 17.0.0-5 (mysticatea#201)
8327d11 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mysticatea mysticatea mysticatea approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

crash on dynamic import with variable

4 participants

@fisker @ehmicky @mysticatea @pagarwal-ignitetech