WIP ✨ update node/no-unsupported-features/node-builtins backported URL / URLSearchParams#194
Closed
moeriki wants to merge 1 commit intomysticatea:masterfrom
moeriki:issue-192-url-URL-support
Closed
WIP ✨ update node/no-unsupported-features/node-builtins backported URL / URLSearchParams#194moeriki wants to merge 1 commit intomysticatea:masterfrom moeriki:issue-192-url-URL-support
moeriki wants to merge 1 commit intomysticatea:masterfrom
moeriki:issue-192-url-URL-support
Conversation
…L / URLSearchParams
Owner
|
Thank you for your contribution. I'm sorry, I have updated the rule with a different approach. Now the Thanks. |
Author
|
Nice 👍 |
brettz9
pushed a commit
to brettz9/eslint-plugin-node
that referenced
this pull request
Jul 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #192
URLandURLSearchParamswas backported to Node.jsv6.13.0.Notice that I had to set
supportedto a more complex range forURLSearchParams.This is atm not very readable because the
supportedvariable is prefixed with<outside of the config.Additionally the lint error output is making little sense as well.
Was not sure how to solve best so I'm leaving this PR for discussion.